Skip to content

Add Terraform-focused Vigilante implementation skill with fmt, validate, and secret-safe infrastructure guidance#373

Merged
nicobistolfi merged 1 commit intomainfrom
vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance
Apr 3, 2026
Merged

Add Terraform-focused Vigilante implementation skill with fmt, validate, and secret-safe infrastructure guidance#373
nicobistolfi merged 1 commit intomainfrom
vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance

Conversation

@nicobistolfi
Copy link
Copy Markdown
Collaborator

@nicobistolfi nicobistolfi commented Apr 1, 2026

Summary

  • Adds TechStackTerraform detection by scanning for .tf files in the repository root
  • Adds a dedicated vigilante-issue-implementation-on-terraform skill with idiomatic Terraform workflow guidance (fmt, validate, init, lint, plan safety, state security, credentials, provider/module hygiene, mixed-language scoping)
  • Adds Terraform security guidance to the prompt builder covering formatting, validation, linting, state security, credentials, provider hygiene, plan safety, and mixed-language repositories
  • Adds skill selection logic: Terraform skill is selected for traditional Terraform-only repos; Go/GitHub Actions/Docker take priority when present; monorepo skills take priority for monorepo shapes
  • Preserves all existing Docker detection, skill, security guidance, and tests unchanged

Test plan

  • TestClassifyTerraformRepoFromTFFiles — detects .tf files as Terraform tech stack
  • TestClassifyNonTerraformRepoHasNoTerraformTechStack — no false positives
  • TestClassifyTerraformAndGoRepoDetectsBoth — dual-stack detection
  • TestIssueImplementationSkillSelectsTerraformForTerraformRepo — correct skill selection
  • TestIssueImplementationSkillPrefersGoOverTerraformForDualStack — priority ordering
  • TestIssueImplementationSkillPrefersMonorepoOverTerraform — monorepo takes precedence
  • TestSecurityGuidanceForTerraformRepo — all guidance sections present
  • TestTerraformMixedLanguageGuidanceIncludedForGoAndTerraform — mixed-language section injected
  • TestTerraformMixedLanguageGuidanceOmittedForTerraformOnly — no mixed-language for pure Terraform
  • TestTerraformSkillIsBundled — skill asset embedded
  • TestTerraformSkillCoversRequiredGuidanceAreas — skill content validated
  • All existing Docker tests continue to pass unchanged

Closes #365

@nicobistolfi nicobistolfi force-pushed the vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance branch 2 times, most recently from 701dbde to 1b8ffa5 Compare April 2, 2026 03:26
@nicobistolfi nicobistolfi changed the title Add Terraform-focused Vigilante implementation skill Add Terraform-focused Vigilante implementation skill with fmt, validate, and secret-safe infrastructure guidance Apr 2, 2026
@nicobistolfi nicobistolfi force-pushed the vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance branch 4 times, most recently from c1b0c7d to 383d49a Compare April 2, 2026 19:14
@nicobistolfi nicobistolfi force-pushed the vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance branch from 383d49a to 7fbf8a8 Compare April 2, 2026 20:46
@nicobistolfi nicobistolfi merged commit 46a5c69 into main Apr 3, 2026
1 check passed
@nicobistolfi nicobistolfi deleted the vigilante/issue-365-add-a-terraform-focused-vigilante-implementation-skill-with-fmt-validate-and-secret-safe-infrastructure-guidance branch April 3, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add a Terraform-focused Vigilante implementation skill with fmt, validate, and secret-safe infrastructure guidance

1 participant