Skip to content

Remove spctl --assess check that blocks Homebrew Cask daemon setup#246

Merged
nicobistolfi merged 2 commits intomainfrom
fix/binary-signing
Mar 19, 2026
Merged

Remove spctl --assess check that blocks Homebrew Cask daemon setup#246
nicobistolfi merged 2 commits intomainfrom
fix/binary-signing

Conversation

@nicobistolfi
Copy link
Copy Markdown
Collaborator

@nicobistolfi nicobistolfi commented Mar 19, 2026

Summary

  • Remove the spctl --assess Gatekeeper check from prepareMacOSDaemonBinary() — ad-hoc signed binaries always fail this check on modern macOS since it enforces Apple notarization policy, which is not required for Homebrew-distributed CLI tools
  • Fix pre-existing test bug where caskRoot was computed before filepath.EvalSymlinks, causing test failures on macOS (where /var/folders/... resolves to /private/var/folders/...)
  • Replace the spctl failure context test with an equivalent codesign failure context test

Fixes #244

Test plan

  • All existing tests pass (go test ./...)
  • Install via Homebrew Cask and verify vigilante setup -d succeeds without the spctl rejection error
  • Verify the daemon loads and runs correctly via launchctl

🤖 Generated with Claude Code

@nicobistolfi nicobistolfi changed the title Binary signing Remove spctl --assess check that blocks Homebrew Cask daemon setup Mar 19, 2026
@nicobistolfi nicobistolfi merged commit 18d224c into main Mar 19, 2026
1 check passed
@nicobistolfi nicobistolfi deleted the fix/binary-signing branch March 19, 2026 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove spctl --assess check that blocks Homebrew Cask daemon setup

1 participant