Skip to content
This repository was archived by the owner on Jan 10, 2023. It is now read-only.

Commit 111a959

Browse files
XaeliasXaelias
committed
XDR] Update XDR metrics to match metrics in 4.5, and update bad type (counter vs. gauge)
1 parent a1998a4 commit 111a959

File tree

2 files changed

+52
-30
lines changed

2 files changed

+52
-30
lines changed

‎namespaces.go

+14-3
Original file line numberDiff line numberDiff line change
@@ -160,9 +160,20 @@ var (
160160
counter("udf_sub_udf_complete", "udf sub udf complete"),
161161
counter("udf_sub_udf_error", "udf sub udf error"),
162162
counter("udf_sub_udf_timeout", "udf sub udf timeout"),
163-
counter("xdr_write_error", "xdr write error"),
164-
counter("xdr_write_success", "xdr write success"),
165-
counter("xdr_write_timeout", "xdr write timeout"),
163+
counter("xdr_client_delete_error", "xdr client delete error"),
164+
counter("xdr_client_delete_not_found", "xdr client delete not found"),
165+
counter("xdr_client_delete_success", "xdr client delete success"),
166+
counter("xdr_client_delete_timeout", "xdr client delete timeout"),
167+
counter("xdr_client_write_error", "xdr client write error"),
168+
counter("xdr_client_write_success", "xdr client write success"),
169+
counter("xdr_client_write_timeout", "xdr client write timeout"),
170+
counter("xdr_from_proxy_delete_error", "xdr from proxy delete error"),
171+
counter("xdr_from_proxy_delete_not_found", "xdr from proxy delete not found"),
172+
counter("xdr_from_proxy_delete_success", "xdr from proxy delete success"),
173+
counter("xdr_from_proxy_delete_timeout", "xdr from proxy delete timeout"),
174+
counter("xdr_from_proxy_write_error", "xdr from proxy write error"),
175+
counter("xdr_from_proxy_write_success", "xdr from proxy write success"),
176+
counter("xdr_from_proxy_write_timeout", "xdr from proxy write timeout"),
166177
gauge("available_bin_names", "available bin names"),
167178
gauge("device_available_pct", "device available pct"),
168179
gauge("device_compression_ratio", "device compression ratio"),

‎stats.go

+38-27
Original file line numberDiff line numberDiff line change
@@ -75,41 +75,52 @@ var (
7575
gauge("fabric_meta_recv_rate", "fabric meta recv rate"),
7676
gauge("fabric_rw_send_rate", "fabric rw send rate"),
7777
gauge("fabric_rw_recv_rate", "fabric rw recv rate"),
78-
counter("xdr_ship_success", "xdr ship success"),
79-
counter("xdr_ship_delete_success", "xdr ship delete success"),
80-
counter("xdr_ship_source_error", "xdr ship source error"),
81-
counter("xdr_ship_destination_error", "xdr ship destination error"),
82-
gauge("xdr_ship_bytes", "xdr ship bytes"),
83-
gauge("xdr_ship_latency_avg", "xdr ship latency avg"),
84-
gauge("xdr_ship_compression_avg_pct", "xdr ship compression avg pct"),
85-
gauge("xdr_ship_inflight_objects", "xdr ship inflight objects"),
86-
gauge("xdr_ship_outstanding_objects", "xdr ship outstanding objects"),
87-
counter("xdr_read_success", "xdr read success"),
88-
counter("xdr_read_error", "xdr read error"),
89-
gauge("xdr_read_notfound", "xdr read notfound"),
90-
gauge("xdr_read_latency_avg", "xdr read latency avg"),
78+
// XDR specific metrics
79+
// requires Aerospike EE
80+
gauge("dlog_free_pct", "dlog free pct"),
81+
counter("dlog_logged", "dlog logged"),
82+
counter("dlog_overwritten_error", "dlog overwritten error"),
83+
counter("dlog_processed_link_down", "dlog processed link down"),
84+
counter("dlog_processed_main", "dlog processed main"),
85+
counter("dlog_processed_replica", "dlog processed replica"),
86+
counter("dlog_relogged", "dlog relogged"),
87+
gauge("dlog_used_objects", "dlog used objects"),
88+
counter("local_recs_migration_retry", "Number of records missing in a batch call"),
89+
counter("stat_pipe_reads_diginfo", "Number of digest information read from the named pipe."),
90+
gauge("xdr_active_failed_node_sessions", "Number of active failed node sessions pending."),
91+
gauge("xdr_active_link_down_sessions", "Number of active link down sessions pending."),
92+
gauge("xdr_global_lastshiptime", "The minimum last ship time in millisecond (epoch) for XDR for across the cluster."),
93+
counter("xdr_hotkey_fetch", "xdr hotkey fetch"),
94+
counter("xdr_hotkey_skip", "xdr hotkey skip"),
95+
counter("xdr_queue_overflow_error", "xdr queue overflow error"),
9196
gauge("xdr_read_active_avg_pct", "xdr read active avg pct"),
97+
counter("xdr_read_error", "xdr read error"),
9298
gauge("xdr_read_idle_avg_pct", "xdr read idle avg pct"),
99+
gauge("xdr_read_latency_avg", "xdr read latency avg"),
100+
counter("xdr_read_notfound", "xdr read notfound"),
93101
gauge("xdr_read_reqq_used", "xdr read reqq used"),
94102
gauge("xdr_read_reqq_used_pct", "xdr read reqq used pct"),
95103
gauge("xdr_read_respq_used", "xdr read respq used"),
104+
counter("xdr_read_success", "xdr read success"),
96105
gauge("xdr_read_txnq_used", "xdr read txnq used"),
97106
gauge("xdr_read_txnq_used_pct", "xdr read txnq used pct"),
98-
gauge("xdr_queue_overflow_error", "xdr queue overflow error"),
99-
gauge("xdr_hotkey_fetch", "xdr hotkey fetch"),
100-
gauge("xdr_hotkey_skip", "xdr hotkey skip"),
101-
counter("xdr_unknown_namespace_error", "xdr unknown namespace error"),
102-
counter("xdr_uninitialized_destination_error", "xdr uninitialized destination error"),
103-
gauge("xdr_timelag", "xdr timelag"),
107+
counter("xdr_relogged_incoming", "Number of records relogged into this node's digest log by another node."),
108+
counter("xdr_relogged_outgoing", "Number of records relogged to another node's digest log. "),
109+
counter("xdr_ship_bytes", "xdr ship bytes"),
110+
gauge("xdr_ship_compression_avg_pct", "xdr ship compression avg pct"),
111+
counter("xdr_ship_delete_success", "xdr ship delete success"),
112+
counter("xdr_ship_destination_error", "xdr ship destination error"),
113+
counter("xdr_ship_destination_permanent_error", "xdr ship destination permanent error"),
114+
gauge("xdr_ship_fullrecord", "Number of records that did not take advantage of bin level shipping."),
115+
gauge("xdr_ship_inflight_objects", "xdr ship inflight objects"),
116+
gauge("xdr_ship_latency_avg", "xdr ship latency avg"),
117+
gauge("xdr_ship_outstanding_objects", "xdr ship outstanding objects"),
118+
counter("xdr_ship_source_error", "xdr ship source error"),
119+
counter("xdr_ship_success", "xdr ship success"),
104120
gauge("xdr_throughput", "xdr throughput"),
105-
gauge("dlog_free_pct", "dlog free pct"),
106-
counter("dlog_logged", "dlog logged"),
107-
counter("dlog_overwritten_error", "dlog overwritten error"),
108-
counter("dlog_processed_link_down", "dlog processed link down"),
109-
counter("dlog_processed_main", "dlog processed main"),
110-
counter("dlog_processed_replica", "dlog processed replica"),
111-
counter("dlog_relogged", "dlog relogged"),
112-
counter("dlog_used_objects", "dlog used objects"),
121+
gauge("xdr_timelag", "xdr timelag"),
122+
counter("xdr_uninitialized_destination_error", "xdr uninitialized destination error"),
123+
counter("xdr_unknown_namespace_error", "xdr unknown namespace error"),
113124
}
114125
)
115126

0 commit comments

Comments
 (0)