Repository navigation
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b36636f380
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
oss-sentinel-ai
left a comment
oss-sentinel-ai
left a comment
There was a problem hiding this comment.
Summary
Reviewed the changes in this PR (191 lines changed). The changes appear to be well-structured.
Observations
- Changes span 191 lines
- Please ensure all edge cases are covered
- Verify test coverage for the modified code paths
Automated review by github-manager-bot
Contributor
Author
|
@yuluo-yx 已重新核对当前 head、最新 main 变化、mergeability、CI、reviews 和 review threads；现有评审意见均已验证并清理，未发现需要追加代码修改的问题。烦请在方便时进行维护者审查，谢谢。 |
yuluo-yx
pushed a commit
to agentic-ai-java/argi
that referenced
this pull request
Oct 15, 2026
Adapt the approach in alibaba/spring-ai-alibaba#4842 to ARGI's neutral ChatMessage and JsonCodec APIs. Preserve legacy single-element dispatch, use overflow-safe cursor arithmetic, and add offline regression tests. Refs #156.
yuluo-yx
pushed a commit
to agentic-ai-java/argi
that referenced
this pull request
Oct 17, 2026
Adapt the approach in alibaba/spring-ai-alibaba#4842 to ARGI's neutral ChatMessage and JsonCodec APIs. Preserve legacy single-element dispatch, use overflow-safe cursor arithmetic, and add offline regression tests. Refs #156.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe what this PR does / why we need it
Adds opt-in batched dispatch to LoopAgent array loops. Callers can now use
LoopMode.array(batchSize)when a sub-agent should process several input elements per iteration, such as processing 20 images in groups of 5.The root cause of the limitation was that
ArrayLoopStrategy.loopDispatchalways selected exactly one list element and incremented its cursor by one. There was no API for controlling the number of elements sent to each iteration.Does this pull request fix one issue?
Fixes #4664
Describe how you did it
LoopMode.array(int batchSize)andLoopMode.array(int batchSize, Converter<...>)overloads.ArrayLoopStrategy.array()andarray(converter)single-element message behavior.User impact: LoopAgent users can express bounded batch processing without wrapping or subclassing agents. Existing users see no behavior change unless they select a batched overload.
Describe how to verify it
Result: BUILD SUCCESS; 593 tests run, 0 failures, 0 errors, 167 environment-dependent tests skipped. Checkstyle and Spotless passed in the same build.
Special notes for reviews
The API change is additive and source compatible. Batched message serialization is only enabled when
batchSizeis explicitly provided; the final batch may contain fewer elements. Non-positive sizes fail fast withIllegalArgumentException.