You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The issue is verified against the current codebase.
Root Cause: In SkillsAgentHook.getModelInterceptors(), the isEmpty() guard prevents an initially-empty groupedTools map from being passed to SkillsInterceptor.Builder:
if (!this.groupedTools.isEmpty()) {
interceptorBuilder.groupedTools(this.groupedTools);
}
When the user passes a ConcurrentHashMap that is empty at construction time and populates it later, the interceptor never receives the map reference because the check fails at the first call.
Workaround (available now): Use groupedToolsSupplier() instead of groupedTools() in the builder. The supplier is invoked lazily on each call and is designed for dynamic tool registration:
Suggested fix: Remove the isEmpty() guard so that the map reference is always passed. Since the map is shared by reference, later mutations will be visible to the interceptor regardless.
Severity: Low-Medium — the groupedToolsSupplier API already covers this use case, but the isEmpty() guard is a footgun for users who pass a mutable map directly.
Activity
Anon2Tokyo commentedon Aug 26, 2026
Hello, I'm very interested in this issue and would like to try to resolve it.
oss-sentinel-ai commentedon Aug 27, 2026
Issue Evaluation
Category:
kind/bug| Area:area/agent-framework| Status: Confirmed ✅The issue is verified against the current codebase.
Root Cause: In
SkillsAgentHook.getModelInterceptors(), theisEmpty()guard prevents an initially-emptygroupedToolsmap from being passed toSkillsInterceptor.Builder:When the user passes a
ConcurrentHashMapthat is empty at construction time and populates it later, the interceptor never receives the map reference because the check fails at the first call.Workaround (available now): Use
groupedToolsSupplier()instead ofgroupedTools()in the builder. The supplier is invoked lazily on each call and is designed for dynamic tool registration:Suggested fix: Remove the
isEmpty()guard so that the map reference is always passed. Since the map is shared by reference, later mutations will be visible to the interceptor regardless.Severity: Low-Medium — the
groupedToolsSupplierAPI already covers this use case, but theisEmpty()guard is a footgun for users who pass a mutable map directly.Automated evaluation by github-manager
Prometheusxiao commentedon Aug 27, 2026
我注意到了你们最新代码提供了supplier的方式,非常感谢你们!