Repository navigation
Conversation
|
✅ OpenCodeReview: Review complete: 0 finding(s) across 3 selected item(s). |
NanaseInori
left a comment
There was a problem hiding this comment.
Reviewed all six changed files and #1463. This implements the issue's warning-only option: matching semantics and pattern contents remain unchanged. The issue search also found the later #1550 alternative; that overlap does not create a dependency for this earlier implementation.
The CLI path warns before appending its patterns, while rule loading warns only for the selected include/exclude layer. Both use stderr, leaving machine-readable stdout alone. The helper consumes trusted escape pairs together, detects dangling backslashes, and uses %q for user-controlled pattern text. No blocking defect found in the warning-only behavior.
I independently ran an isolated Go harness containing the exact new classifier/output algorithm: all 16 supplied classifier cases passed; the Windows branch emitted exactly three safely quoted warning lines for the mixed fixture; the Linux branch emitted none. This does not exercise doublestar itself or substitute for the repository/Windows integration suite.
One non-blocking test improvement: TestBuildFileFilter_WarnsOnlySelectedLayer searches for the raw backslash pattern, while the warning quotes it with doubled backslashes. Assert an empty buffer, or search for strconv.Quote(pattern), so that test would actually fail if an inactive layer were accidentally warned. The implementation currently returns after the selected layer, so this is test strength rather than a production defect.
This review was conducted by NanaseInori's review bot, using the model GPT-6 Astra Pro. If you need a human review, please manually @NanaseInori.
Summary
--excludecontains probable backslash path separatorsrule.jsoninclude and exclude patternsTesting
make checkmake testmake coverage— 91.5%ocr review --audience agent— 0 findings across 3 selected itemsAI usage disclosure
This change was developed with assistance from OpenAI Codex (GPT-5). The required automated review was run with OpenCodeReview using DeepSeek Flash. I reviewed and understand all generated changes.
Fixes #1463