feat(allowlist): add Jinja template support by dvd233 · Pull Request #1056 · alibaba/open-code-review

dvd233 · 2026-08-25T08:16:30Z

Description

Add first-class review support for Jinja template files as the focused subtask tracked in #1055:

recognize .jinja2 and .j2 files case-insensitively;
route them to a dedicated Jinja review rule covering escaping contexts, template injection, undefined values, includes/imports/macros, output correctness, and render-time performance;
test lowercase and uppercase allowlist and rule resolution;
document the new built-in mapping in all five review-rules locale pages.

Type of Change

Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Refactoring (no functional changes)
Documentation update
CI / Build / Tooling

How Has This Been Tested?

make test passes locally
Manual testing (described below)

Validation performed on Windows/amd64 with Go 1.27.0, GNU Make 4.4.1, and GCC 16.2.0:

make check
make test (all 23 Go packages with -race -count=1)
make build
go test -race -count=1 ./internal/config/allowlist ./internal/config/rules
Pages lint, 32 tests, typecheck, production webpack build, bundle-size check, and HTTP smoke checks for the built site

The repository-required ocr review --audience agent --background "briefly summarize the background requirements" command was attempted, but this local environment has no configured LLM endpoint. I completed a separate standards/spec self-review; both axes reported no remaining findings.

Checklist

My code follows the project's coding style (go fmt, go vet)
I have performed a self-review of my code
I have added tests that prove my fix is effective or my feature works
New and existing unit tests pass locally with my changes
I have updated the documentation accordingly (if applicable)
I have signed the CLA

Related Issues

Closes #1055

Part of #470

Follow-up: conflict resolution repair (2026-09-29)

Restore the upstream allowlist and rule-mapping order, remove redundant legacy patterns introduced during conflict resolution, and put the Jinja row next to the other template rules in all five documentation locales. The intended Jinja extensions, rule document, and existing co-author attribution are preserved.

Validation on Windows/amd64 with Go 1.27.1:

make check and make build passed.
All 23 Go packages with tests passed race-enabled tests across the full run and a focused rerun. The initial full run had three packages fail because temporary non-repository fixtures inherited the enclosing repository. Setting GIT_CEILING_DIRECTORIES to the task's temporary root restored isolation; those three packages then passed without source or test changes.
Parsed comparisons verified that all upstream allowlist entries and rule mappings retain their original order, with only the intended Jinja additions.
All five documentation locales preserve the upstream text except for the Jinja row, in matching order. README translation checks and git diff --check passed.
The required ocr review --audience agent --background ... was attempted again and exited because no valid LLM endpoint is configured; an automated OCR review result is unavailable.

AI assistance

Codex (GPT-6) assisted with the conflict-resolution repair and its validation. The author's personal review is required before requesting further maintainer review.

CLAassistant · 2026-08-25T08:16:53Z

All committers have signed the CLA.

github-actions · 2026-08-25T08:17:23Z

✅ OpenCodeReview: Review complete: 0 finding(s) across 2 selected item(s).

dvd233 · 2026-08-25T10:27:22Z

@wu21-web The requested documentation wording has been shortened in 46d669c, and the review thread has been resolved. Could you please take another look when convenient? Thanks!

Qiyuanqiii

The PR description has been flattened into a single Markdown line, so its headings, lists, and checkboxes do not render correctly. Please edit the PR description to restore the intended line breaks and blank lines.

Qiyuanqiii · 2026-08-25T11:23:18Z

The problem appears like this

dvd233 · 2026-08-25T11:25:08Z

@Qiyuanqiii Fixed — the PR description has been restored with its headings, lists, blank lines, and task checkboxes rendering correctly. The CLA item remains checked. Thanks for catching this!

Qiyuanqiii

GitHub Linguist lists .jinja as Jinja’s primary extension. Since this PR is intentionally scoped to .jinja2 and .j2 per #1055, this does not need to block the PR, but it would be useful to track .jinja support in a follow-up issue.

wu21-web

@dvd233 Merge conflicts, please rebase main and I will review.

dvd233 · 2026-08-25T13:34:36Z

@wu21-web Rebased onto the latest main (cfbb62e) and resolved the conflicts while preserving both the upstream MATLAB support and this PR's Jinja support. Local validation passed: make check, make test (with -race -count=1), make build, and the Pages lint/test/typecheck/build/size checks. The PR is now conflict-free. Could you please review again? Thanks!

wu21-web

Overall this is complete. I would approve this.

wu21-web

LGTM

dvd233 · 2026-08-26T14:15:43Z

All review suggestions are addressed and checks are green — this is ready from my side whenever you'd like to merge. Thanks again for the thorough reviews!

Co-authored-by: Tao Xin <[email protected]>

wu21-web

LGTM

lizhengfeng101 · 2026-09-21T12:08:32Z

@dvd233 Please resolve the merge conflicts~

lizhengfeng101 · 2026-09-23T12:05:18Z

@dvd233 Please resolve the merge conflicts~

…mplate-support # Conflicts: # internal/config/allowlist/allowed_ext_test.go # internal/config/allowlist/supported_file_types.json # internal/config/rules/system_rules.json # internal/config/rules/system_rules_test.go # pages/src/content/docs/en/review-rules.md # pages/src/content/docs/ja/review-rules.md # pages/src/content/docs/ko/review-rules.md # pages/src/content/docs/ru/review-rules.md # pages/src/content/docs/zh/review-rules.md

lizhengfeng101

@dvd233 It seems that resolving the conflicts has caused some issues; please check it.

lizhengfeng101

LGTM

Locoabordo

Git

Locoabordo · 2026-09-29T21:54:05Z

Git Status

Locoabordo · 2026-09-29T21:54:31Z

No text conflicts. The trial merge built, vetted and passed the full test suite; coverage stays at 90.9%. Checked for silent parity breaks: upstream left the filter sources (internal/agent/selection.go, preview.go, internal/diff) untouched. The only rule-data change is the Jinja allowlist (alibaba#1056, .jinja2 and .j2), which `ocr core diff` inherits through the shared allowlist package. The branch delta against v1.12.11 matches the pre-merge delta against v1.12.9, so no upstream-deleted code came back. Co-Authored-By: Claude Opus 5.5 <[email protected]>

wu21-web reviewed Aug 25, 2026

View reviewed changes

Comment thread pages/src/content/docs/en/review-rules.md Resolved

Qiyuanqiii reviewed Aug 25, 2026

View reviewed changes

Qiyuanqiii approved these changes Aug 25, 2026

View reviewed changes

wu21-web suggested changes Aug 25, 2026

View reviewed changes

dvd233 force-pushed the codex/feat/jinja-template-support branch from 46d669c to 7b7b2e9 Compare August 25, 2026 13:31

wu21-web approved these changes Aug 25, 2026

View reviewed changes

Comment thread internal/config/allowlist/supported_file_types.json Resolved

wu21-web approved these changes Aug 25, 2026

View reviewed changes

dvd233 and others added 3 commits August 29, 2026 16:54

feat(allowlist): add Jinja template support

e5e0495

docs: shorten Jinja rule descriptions

fa40eae

Co-authored-by: Tao Xin <[email protected]>

refactor(allowlist): group Jinja entries with templates

3736838

Co-authored-by: Tao Xin <[email protected]>

dvd233 force-pushed the codex/feat/jinja-template-support branch from 7054aa9 to 3736838 Compare August 29, 2026 09:13

wu21-web approved these changes Aug 29, 2026

View reviewed changes

This was referenced Sep 23, 2026

feat(allowlist): expand supported file types — language experts wanted #470

Open

feat(allowlist): add EJS, Liquid and Nunjucks template support #1553

Merged

lizhengfeng101 reviewed Sep 28, 2026

View reviewed changes

fix(config): preserve upstream rules after Jinja conflict resolution

d4fac89

lizhengfeng101 approved these changes Sep 29, 2026

View reviewed changes

Merge branch 'main' into codex/feat/jinja-template-support

7a2b86f

lizhengfeng101 merged commit a758d9c into alibaba:main Sep 29, 2026
15 checks passed

Locoabordo reviewed Sep 29, 2026

View reviewed changes

Conversation

dvd233 commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Type of Change

How Has This Been Tested?

Checklist

Related Issues

Follow-up: conflict resolution repair (2026-09-29)

AI assistance

Uh oh!

CLAassistant commented Aug 25, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Aug 25, 2026

Uh oh!

Uh oh!

dvd233 commented Aug 25, 2026

Uh oh!

Qiyuanqiii left a comment

Choose a reason for hiding this comment

Uh oh!

Qiyuanqiii commented Aug 25, 2026

Uh oh!

dvd233 commented Aug 25, 2026

Uh oh!

Qiyuanqiii left a comment

Choose a reason for hiding this comment

Uh oh!

wu21-web left a comment

Choose a reason for hiding this comment

Uh oh!

dvd233 commented Aug 25, 2026

Uh oh!

wu21-web left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

wu21-web left a comment

Choose a reason for hiding this comment

Uh oh!

dvd233 commented Aug 26, 2026

Uh oh!

wu21-web left a comment

Choose a reason for hiding this comment

Uh oh!

lizhengfeng101 commented Sep 21, 2026

Uh oh!

lizhengfeng101 commented Sep 23, 2026

Uh oh!

lizhengfeng101 left a comment

Choose a reason for hiding this comment

Uh oh!

lizhengfeng101 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Locoabordo left a comment

Choose a reason for hiding this comment

Uh oh!

Locoabordo commented Sep 29, 2026

Uh oh!

Locoabordo commented Sep 29, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

dvd233 commented Aug 25, 2026 •

edited

Loading

CLAassistant commented Aug 25, 2026 •

edited

Loading