fix: add Java 8 TimeModule support#3935
Merged
wenshao merged 4 commits intoalibaba:mainfrom Jan 11, 2026
Merged
Conversation
Contributor
|
你好,我发现好像似乎没有支持所有的time类型 |
Collaborator
|
温老师对性能要求很高的,我觉得部分类型可能需要 ObjectReaderImplXxx …… |
Collaborator
|
我觉得可以先不着急兼容所有时间类型,可以先拿已实现的几个类型跑一下 JMH BenchMark(可以和 Jackson 做下对比,也可以是其它),这样可能更容易被接受 |
Contributor
Author
Collaborator
|
👍,能否提供 benchmark 测试代码?可以用下面方式折叠起来,更方便查看 |
Contributor
Author
可以具体说一下还有哪些没支持吗?谢谢了! |
Member
|
这些Reader有JSONB的实现,所以要补上JSONB相关的测试 |
Contributor
Author
Member
|
没看到有补充JSONB部分测试覆盖代码的提交记录啊 |
Contributor
Author
我忘提交到这个分支了,跑完JMH给忘了温老师 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.


What this PR does / why we need it?
增加Year、YearMonth、MonthDay 的支持和一部分测试,还缺少什么可以补充下,谢谢🙏了呀
但是貌似Jackson不支持HijrahDate这种,其他是正常的,但其他的肯定是优于Jackson的性能的
Summary of your change
Close #3857
点击查看测试代码
Jackson依赖版本
tools.jackson.core jackson-databind 3.0.2Please indicate you've done the following: