Skip to content

Add method comments and adjust code block placement#38

Merged
wenshao merged 2 commits intoalibaba:mainfrom
kraity:main
Apr 21, 2022
Merged

Add method comments and adjust code block placement#38
wenshao merged 2 commits intoalibaba:mainfrom
kraity:main

Conversation

@kraity
Copy link
Copy Markdown
Collaborator

@kraity kraity commented Apr 21, 2022

JSONArrayJSONObject中简单地添加方法的注释以及调整了代码块位置

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 21, 2022

Codecov Report

Merging #38 (b45939a) into main (cf72621) will decrease coverage by 0.01%.
The diff coverage is 84.03%.

@@             Coverage Diff              @@
##               main      #38      +/-   ##
============================================
- Coverage     67.61%   67.59%   -0.02%     
+ Complexity     7414     7412       -2     
============================================
  Files           373      373              
  Lines         40789    40759      -30     
  Branches       8079     8048      -31     
============================================
- Hits          27579    27553      -26     
+ Misses         9808     9805       -3     
+ Partials       3402     3401       -1     
Impacted Files Coverage Δ
...rc/main/java/com/alibaba/fastjson2/JSONObject.java 84.34% <82.73%> (-0.22%) ⬇️
...src/main/java/com/alibaba/fastjson2/JSONArray.java 93.43% <86.48%> (-0.30%) ⬇️
.../alibaba/fastjson2/reader/ObjectReaderImplMap.java 64.65% <0.00%> (-0.42%) ⬇️
...in/java/com/alibaba/fastjson2/JSONWriterJSONB.java 57.99% <0.00%> (+0.18%) ⬆️
...ain/java/com/alibaba/fastjson2/JSONWriterUTF8.java 74.96% <0.00%> (+0.25%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cf72621...b45939a. Read the comment docs.

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 21, 2022

Issue和文档都可以用中文,但代码注释还是不用中文吧

@kraity
Copy link
Copy Markdown
Collaborator Author

kraity commented Apr 21, 2022

Issue和文档都可以用中文,但代码注释还是不用中文吧

我最初也计划是注释不用含中文, 考虑到国人的使用, 才加上的

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 21, 2022

代码注释还是先不用中文吧

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 21, 2022

可以加我微信 wenshaojin ,有直接联系方式后,有活动礼品方便寄给你

@kraity
Copy link
Copy Markdown
Collaborator Author

kraity commented Apr 21, 2022

可以加我微信 wenshaojin ,有直接联系方式后,有活动礼品方便寄给你

好的谢谢温少大佬!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants