Skip to content

fix #18#23

Closed
kraity wants to merge 2 commits intoalibaba:mainfrom
kraity:main
Closed

fix #18#23
kraity wants to merge 2 commits intoalibaba:mainfrom
kraity:main

Conversation

@kraity
Copy link
Copy Markdown
Collaborator

@kraity kraity commented Apr 20, 2022

No description provided.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Apr 20, 2022

CLA assistant check
All committers have signed the CLA.

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 20, 2022

两个commit分开两个PR吧,毕竟是两个不同的事情,同时testcase跑不过,你看下

@kraity
Copy link
Copy Markdown
Collaborator Author

kraity commented Apr 20, 2022

两个commit分开两个PR吧,毕竟是两个不同的事情,同时testcase跑不过,你看下

跑不过原因是项目使用了Unsafe而它被声明未来可能会删除

Warning:  /home/runner/work/fastjson2/fastjson2/core/src/main/java/com/alibaba/fastjson2/util/UnsafeUtils.java:[4,16] sun.misc.Unsafe is internal proprietary API and may be removed in a future release

理论上与提交的commit没联系

@kraity kraity closed this Apr 20, 2022
@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 20, 2022

这个是warning,现在是能跑过的

@wenshao
Copy link
Copy Markdown
Member

wenshao commented Apr 20, 2022

com.alibaba.fastjson2.codec.JSONBTableTest2
这个testcase有问题,我已经修复,你重新提交吧

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants