Skip to content

Porting photon/thread/* to Windows with mingw#185

Merged
beef9999 merged 4 commits into
alibaba:mainfrom
lihuiba:windows
Sep 20, 2023
Merged

Porting photon/thread/* to Windows with mingw#185
beef9999 merged 4 commits into
alibaba:mainfrom
lihuiba:windows

Conversation

@lihuiba

@lihuiba lihuiba commented Sep 13, 2023

Copy link
Copy Markdown
Collaborator

all cases in thread's UT are passed

lihuiba added 3 commits August 7, 2023 21:55
 g++ -std=c++17 -I ../../include/ ../thread-pool.cpp ../workerpool.cpp test.cpp ../thread-key.cpp ../../common/identity-pool.cpp x.cpp ../../common/alog.cpp -D_POSIX_C_SOURCE -O2 -DTEST

note that:
1. -std=c++17 is required (but I don't konw why);
2. -D_POSIX_C_SOURCE is required for alog.cpp to use gmtime_r();
3. -DTEST is required for x.cpp to provide mocks of photon::init() and photon::fini();
x
in thread/test/
g++ -std=c++17 -I ../../include/ -DThreadUT test.cpp x.cpp ../thread-pool.cpp ../workerpool.cpp ../thread-key.cpp ../../common/identity-pool.cpp ../../common/alog.cpp -lgtest -lgflags -O2
@CLAassistant

CLAassistant commented Sep 13, 2023

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@beef9999 beef9999 merged commit 56fb370 into alibaba:main Sep 20, 2023
@lihuiba

lihuiba commented Oct 13, 2023

Copy link
Copy Markdown
Collaborator Author

image

@lihuiba lihuiba deleted the windows branch January 3, 2024 04:20
@lihuiba lihuiba restored the windows branch February 17, 2025 02:07
@lihuiba lihuiba deleted the windows branch February 17, 2025 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants