fix(modal): Fixes issue with index typings on DocSearchModal#2760
Merged
fix(modal): Fixes issue with index typings on DocSearchModal#2760
Conversation
8bittitan
requested review from
NatanTechofNY,
dylantientcheu,
pipeline1987,
shortcuts and
vascobettencourt
as code owners
✅ Deploy Preview for docsearch canceled.
|
dylantientcheu
approved these changes
Sep 16, 2025
NatanTechofNY
approved these changes
Sep 16, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a TS/runtime issue when rendering the
<DocSearchModal />directly after the recentindexNamedeprecation. This moves the fallback safeguard within the modal itself to allow the index props to be passed directly to it.