fix: use vite instead of parcel in the examples#2329
Merged
Conversation
✅ Deploy Preview for docsearch ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
shortcuts
approved these changes
Oct 31, 2024
| const onClose = React.useCallback(() => { | ||
| setIsOpen(false); | ||
| }, [setIsOpen]); | ||
| setInitialQuery(props?.initialQuery); |
Member
There was a problem hiding this comment.
was this to fix the issue of the character leftover?
Contributor
Author
There was a problem hiding this comment.
yes ! but in only works for the playground, for the website this is done inside docusaurus directly so I will port the bug fix there
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Parcel would delete some random file like
identitybecause it though it was not used,viteis smarter.Also remove unused imports