fix(specs): fix missing params and types#772
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
|
|
shortcuts
force-pushed
the
fix/specs-params
branch
from
1e7152e to
d66ca98
Compare
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
force-pushed
the
fix/specs-params
branch
from
d66ca98 to
48cd2a1
Compare
shortcuts
requested review from
a team,
damcou and
millotp
and removed request for
a team
shortcuts
force-pushed
the
fix/specs-params
branch
from
9e6535a to
7a2a716
Compare
millotp
left a comment
millotp
left a comment
There was a problem hiding this comment.
nothing to add on the specs, waiting on the codegen :)
| "forwardToReplicas": "true" | ||
| } | ||
| } | ||
| }, |
millotp
left a comment
millotp
left a comment
There was a problem hiding this comment.
The generated looks good, one last comment !
| - $ref: '#/searchFiltersNestedArrayString' | ||
| x-categories: | ||
| - Advanced | ||
| - $ref: '#/listOfSearchFilters' |
There was a problem hiding this comment.
it's too bad that all of those filters are the same type but different object, it means they are not compatible in java just because we want a different description
There was a problem hiding this comment.
Yup indeed, but there's also a benefit of doing this is that you call the constructor with the same name of the object you are trying to build, while with a single object it would be something like SearchFilters
3 participants
🧭 What and Why
🎟 JIRA Ticket: https://algolia.atlassian.net/browse/APIC-553
Changes included:
There's a lot of spec changes that has been implemented on some clients but not been documented. In this PR, I've took a look at a few of them to find some fixes to apply, but also find some myself.
I'll split the PR if it becomes too big
filterswrongly typedreRankingApplyFilteris nullableinsideBoundingBoxcan be a stringgetAbTestmissing response fieldConsequencePromoteallow group promotecustomNormalizationinindexSettingshasPendingMappingsresponse is incorrectConsequenceQueryallOf definition is wrongqueryoverlap withsearchParams, which makes type wrong (for at least Java and JavaScript)consequenceshould be optionalabtestinghas its own client🧪 Test
CI :D