Repository navigation
Commit 1ac920a
authored
[web] Unskip web tests that now pass in gestures, services, and widgets (flutter#193512)
Removes or narrows 5 web skips across 5 framework test files:
-
`packages/flutter/test/gestures/gesture_binding_resample_event_test.dart`:
removes the `skip: isBrowser` from the shared `testResampleEvent`
helper. Pointer event resampling under `fakeAsync` now works on web, so
every resample test in the file runs on web.
- `packages/flutter/test/widgets/binding_test.dart`: narrows the skip on
`defaultStackFilter elides framework Element mounting stacks` from
`kIsWeb` to `kIsWasm`. It passes with CanvasKit but still fails with
Skwasm, which flutter#87875 continues
to track.
- `packages/flutter/test/widgets/keep_alive_test.dart`: unskips
`KeepAlive render tree description`. The test only failed because the
expected `RenderView` description used `Platform.operatingSystem`.
`RenderView.debugFillProperties` prints `Web` on web (`kIsWeb ? 'Web' :
Platform.operatingSystem`), so the two expected strings now match that
logic.
- `packages/flutter/test/widgets/app_overrides_test.dart`: unskips
`showPerformanceOverlayOverride true`. The test only checks that a
`PerformanceOverlay` widget is inserted into the tree, which works on
web. It does not depend on the overlay rendering stats, which is what
flutter#52258 tracks.
- `packages/flutter/test/services/scribe_test.dart`: unskips `when
receiving an unsupported message`, which checks that an unsupported
`flutter/scribe` platform message returns a `null` response (the
`MissingPluginException` is caught). Platform message handling behaves
the same on web, so the `[intended]` skip is unnecessary. The other
`[intended]` web skips in this file are unchanged.
Fixes flutter#87067
Fixes flutter#87876
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant in-code documentation (doc comments with
`///`).
- [x] If this PR introduces a new feature or capability, I created and
linked a website documentation issue or PR in [flutter/website] (or
verified none is needed).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[flutter/tests]: https://github.com/flutter/tests
[flutter/website]: https://github.com/flutter/website
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Discord]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Chat.md
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md1 parent 62bae03 commit 1ac920a
5 files changed
Lines changed: 7 additions & 8 deletions
File tree
- packages/flutter/test
- gestures
- services
- widgets
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
56 | 56 | | |
57 | 57 | | |
58 | 58 | | |
59 | | - | |
60 | | - | |
| 59 | + | |
61 | 60 | | |
62 | 61 | | |
63 | 62 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
23 | 23 | | |
24 | 24 | | |
25 | 25 | | |
26 | | - | |
| 26 | + | |
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
36 | 36 | | |
37 | 37 | | |
38 | 38 | | |
39 | | - | |
| 39 | + | |
40 | 40 | | |
41 | 41 | | |
42 | 42 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
837 | 837 | | |
838 | 838 | | |
839 | 839 | | |
840 | | - | |
| 840 | + | |
841 | 841 | | |
842 | 842 | | |
843 | 843 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
211 | 211 | | |
212 | 212 | | |
213 | 213 | | |
214 | | - | |
| 214 | + | |
215 | 215 | | |
216 | 216 | | |
217 | 217 | | |
| |||
364 | 364 | | |
365 | 365 | | |
366 | 366 | | |
367 | | - | |
| 367 | + | |
368 | 368 | | |
369 | 369 | | |
370 | 370 | | |
| |||
549 | 549 | | |
550 | 550 | | |
551 | 551 | | |
552 | | - | |
| 552 | + | |
553 | 553 | | |
0 commit comments