Skip to content

Comments

Linting#12

Merged
ldeaett merged 26 commits intomasterfrom
linting
Aug 6, 2024
Merged

Linting#12
ldeaett merged 26 commits intomasterfrom
linting

Conversation

@alexhutman
Copy link
Owner

Lint Cython files

@alexhutman alexhutman force-pushed the linting branch 6 times, most recently from ca4a871 to 784cb05 Compare July 30, 2024 20:10
Tests shouldn't be included in the sdist nor installation.
Causing too many issues for little gain. If there's a dummy package, maybe we can use that, but it should be known that Sage is needed.
@alexhutman alexhutman force-pushed the linting branch 17 times, most recently from ca0830b to e979d55 Compare July 30, 2024 23:01
@alexhutman
Copy link
Owner Author

Hmm... currently running into an OOM issue during linting. Not really sure why, I'd think that building the wavefront code might require more memory. Might have to separate the linting workflow...

@alexhutman
Copy link
Owner Author

Okay I think that OOM issue will be resolved. According to this, workflow_run can only be called on workflows existing in the default, in our case master, branch... 😵‍💫 So we might have to just merge and see if the linting workflow runs after build_and_test.

@alexhutman
Copy link
Owner Author

@ldeaett Sorry for the noise, thought I was ready but had to tweak some things. I think it's good now whenever you're ready. Just please don't merge yet -- next time we meet, we can do a working session where I show you how I'd clean up these commits a bit more before merging to master.

@alexhutman
Copy link
Owner Author

@ldeaett Sorry for the noise, thought I was ready but had to tweak some things. I think it's good now whenever you're ready. Just please don't merge yet -- next time we meet, we can do a working session where I show you how I'd clean up these commits a bit more before merging to master.

Cancel that @ldeaett, you can merge whenever you approve. Just please rebase and merge! The commits could be worse...

Copy link
Collaborator

@ldeaett ldeaett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants