Merged
Conversation
LICENSE is automatically included in `license_files`. https://setuptools.pypa.io/en/stable/references/keywords.html
Seems like the classifier handles the License on PyPI. https://test.pypi.org/project/zeroforcing/0.1.1.dev1/
Build from sdist was failing because VERSION was not being included. Also added a few other things that should be picked up by default just in case.
ldeaett
approved these changes
Jul 27, 2024
Collaborator
ldeaett
left a comment
ldeaett
left a comment
There was a problem hiding this comment.
Looks pretty good to me! Getting closer! I have a couple of new thoughts about (a) the name of the package itself and (b) our description (in the README) of what it does, but those are probably above and beyond this pull request.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just setting things up nicer with automatic versioning via a VERSION file and making the webpage prettier on PyPI.
Check out what it will look like here!