Make error message in clearer when registering methods that have the same name.

alexbclarke · alexbclarke · commit 7c98955975d5 · 2017-07-09T14:33:30.000+01:00
diff --git a/Json-Rpc/SMDService.cs b/Json-Rpc/SMDService.cs
@@ -43,14 +43,18 @@ public SMD ()
         //}
 
         // alexbclarke: Suggesed fix.
-        // Check is a method has already been added before adding it.
         internal void AddService(string method, Dictionary<string, Type> parameters, Dictionary<string, object> defaultValues, Delegate dele)
         {
             if (!Services.ContainsKey(method))
             {
                 var newService = new SMDService(transport, "JSON-RPC-2.0", parameters, defaultValues, dele);
                 Services.Add(method, newService);
             }
+            else
+            {
+                throw new ArgumentException($"Failed to register method '{method}' in class '{dele.Target.ToString()}'. " + 
+                                            "A method with the same name has already been registered.");
+            }
         }
 
         public static int AddType(JObject jo)

Original file line number	Diff line number	Diff line change
`@@ -43,14 +43,18 @@ public SMD ()`
`43`	`43`	`//}`
`44`	`44`
`45`	`45`	`// alexbclarke: Suggesed fix.`
`46`		`- // Check is a method has already been added before adding it.`
`47`	`46`	`internal void AddService(string method, Dictionary<string, Type> parameters, Dictionary<string, object> defaultValues, Delegate dele)`
`48`	`47`	`{`
`49`	`48`	`if (!Services.ContainsKey(method))`
`50`	`49`	`{`
`51`	`50`	`var newService = new SMDService(transport, "JSON-RPC-2.0", parameters, defaultValues, dele);`
`52`	`51`	`Services.Add(method, newService);`
`53`	`52`	`}`
	`53`	`+ else`
	`54`	`+ {`
	`55`	`+ throw new ArgumentException($"Failed to register method '{method}' in class '{dele.Target.ToString()}'. " +`
	`56`	`+ "A method with the same name has already been registered.");`
	`57`	`+ }`
`54`	`58`	`}`
`55`	`59`
`56`	`60`	`public static int AddType(JObject jo)`