I added tada.wav and tada code in Makefile#298
Merged
alekmaul merged 1 commit intoalekmaul:developfrom Jan 18, 2025
BrunoRNS:tada-changes
Merged
I added tada.wav and tada code in Makefile#298alekmaul merged 1 commit intoalekmaul:developfrom BrunoRNS:tada-changes
alekmaul merged 1 commit intoalekmaul:developfrom
BrunoRNS:tada-changes
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This Pull Request fixes the issue #297 cited by Alekmaul
This PR adds the .wav file and the command line (inside the makefile) that uses snesbrr to convert the wave sound in brr format. I hope this update help users understand the conversion process more effectively.
I created the tada.wav using snesbrr -d tada.brr.
I've made a test using my pvsneslib's Windows automatic version, snes-ide, and worked nice. But I didn't test the Makefile in my Linux Ubuntu yet, but I think it will work too.
Let me know if any adjustments are needed!