Music inside HiROM mapped rom example and mouse support bug fixes#280
Merged
alekmaul merged 2 commits intoalekmaul:developfrom Apr 14, 2024
Merged
Music inside HiROM mapped rom example and mouse support bug fixes#280alekmaul merged 2 commits intoalekmaul:developfrom
alekmaul merged 2 commits intoalekmaul:developfrom
Conversation
soundbank is smaller than $10000 in size, so it fits in one single bank. Musical theme rearranged and some fun animations have been added ;)
I removed a branch present in bios, so both ports are read in one single vblank interrupt. detectMouse() is called later, after nmi, so mouse is detected. snes_mouse is set to 0 when both mouses are not found, not the second one, this is to prevent potential issues.
DigiDwrf
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Music inside HiROM mapped rom example
soundbank is smaller than $10000 in size, so it fits in one single bank.
Musical theme rearranged and some fun animations have been added ;)
Bug fixes for mouse input and example
I removed a branch present in bios, so both ports are read in one single vblank interrupt.
detectMouse() is called later, after nmi, so mouse is detected. snes_mouse is set to 0 when both mouses are not found, not the second one, this is to prevent potential issues.