Optimize Makefile to build tcc and wla-dx#188
Merged
RetroAntho merged 2 commits intoalekmaul:developfrom Apr 10, 2023
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi all,
Here some small improvements for the
compiler/Makefile.Makefilenow defines variables for directory paths and build types to improve readability and maintainability..DEFAULT_GOALdirective, so it's not necessary to specify the target on the command line..PHONYdirective, which is considered good practice.tccis now a separate target that can be invoked independently, which may help with debugging or development.Makefilenow uses$(MAKE)instead of hardcodedmaketo improve portability.CMAKE_GENERATORoption is now passed explicitly to the wla target, which was previously hardcoded in the command line.wla-dx/binariesdirectory instead of invoking make again, which should save some time.Overall, these changes should make the
Makefilemore robust and efficient, while also improving its readability and maintainability.