Rename gas security checker to gosec #505

ccojocar · 2018-07-22T16:36:05Z

alecthomas · 2018-07-22T22:17:06Z

Tests are not working.

ccojocar · 2018-07-23T13:36:43Z

@alecthomas I had to rework a bit the test. gosec expects now the files to be in the GOPATH, because it analyses the entire package. It doesn't work any more with temporary files.

cc @gcmurphy

kolyshkin · 2018-07-24T10:22:15Z

This should also fix issue reported in #499 (comment)

alecthomas · 2018-07-24T10:54:42Z

regressiontests/gosec_test.go

+
+func TestGosec(t *testing.T) {
+	t.Parallel()
+	gopath := os.Getenv("GOPATH")


Can you please change this to create a new GOPATH in a temporary directory? You can use gotest.tools/fs to do this fairly easily.

You might need to have a GOPATH with two entries - the existing one and the temporary one.

alecthomas · 2018-07-24T10:55:42Z

.goreleaser.yml

    goarch: *goarch
    env: *env
-    main: ./_linters/src/github.com/GoASTScanner/gas
+    main: ./_linters/src/github.com/securego/gosec


Is this the main command target?

alecthomas · 2018-07-24T10:58:06Z

Thanks for this, I appreciate it.

ccojocar · 2018-07-24T14:10:01Z

@alecthomas Thanks for your suggestion. I fixed the test code accordantly.

alecthomas · 2018-07-24T14:16:27Z

Brilliant, thanks!

thepwagner · 2018-07-24T17:03:40Z

README.md

 - [unconvert](https://github.com/mdempsky/unconvert) - Detect redundant type conversions.
 - [goconst](https://github.com/jgautheron/goconst) - Finds repeated strings that could be replaced by a constant.
- [gas](https://github.com/GoASTScanner/gas) - Inspects source code for security problems by scanning the Go AST.
+- [goesc](https://github.com/securego/gosec) - Inspects source code for security problems by scanning the Go AST.


Thanks. I fixed it in #506

Guys changed linter name here alecthomas/gometalinter#505

Follows alecthomas/gometalinter#505

* Rename gas to gosec Follows alecthomas/gometalinter#505

JeanMertz · 2018-07-27T08:05:08Z

Could it be that this change breaks usage of // nolint: gosec?

I can still disable using // nolint, but not when I only want to disable gosec.

HaraldNordgren · 2018-07-28T17:31:41Z

@alecthomas @ccojocar

This is a breaking change. We were running the linter with --disable=gosec, which then started giving issues when the rule was renamed.

Could you please bump the major version to v3.0.0?

Tools like http://labix.org/gopkg.in are designed so that breaking changes have to go into major versions.

dnephin · 2018-07-28T17:40:12Z

This change is not yet part of a release. If you're concerned about breaking changes use a tag. v2.0.6 is the latest.

alecthomas · 2018-07-28T22:45:50Z

Hello @ccojocar, this change appears to be having some issues. See #510 for example. Mind taking a look?

…#505]

See alecthomas/gometalinter#505

Rename gas security checker to gosec

cc0ea54

ccojocar added 2 commits July 23, 2018 15:30

Update the gosec linter

e6e7e18

Rework the gosec test to create the test files in the GOPATH

5b4c8d0

Fix the install path for gosec

6372d46

kolyshkin mentioned this pull request Jul 24, 2018

Add go 1.11.0 #499

Merged

alecthomas suggested changes Jul 24, 2018

View reviewed changes

ccojocar added 2 commits July 24, 2018 16:03

Add the temp directory to the GOPATH before running the ggosec test

77a6ba5

Fix the main command target in the configuration of goreleaser

d9cc7cf

alecthomas approved these changes Jul 24, 2018

View reviewed changes

alecthomas merged commit 445bce7 into alecthomas:master Jul 24, 2018

thepwagner reviewed Jul 24, 2018

View reviewed changes

titusjaka added a commit to moira-alert/moira that referenced this pull request Jul 25, 2018

Guys changed linter name here alecthomas/gometalinter#505

1f71f86

titusjaka mentioned this pull request Jul 25, 2018

Guys changed linter name here alecthomas/gometalinter#505 moira-alert/moira#97

Merged

titusjaka added a commit to moira-alert/moira that referenced this pull request Jul 25, 2018

Merge pull request #97 from moira-alert/hotfix/go-bless-metalinter

2e612b7

Guys changed linter name here alecthomas/gometalinter#505

gdbelvin added a commit to gdbelvin/keytransparency that referenced this pull request Jul 25, 2018

Rename gas to gosec

e6fb32c

Follows alecthomas/gometalinter#505

gdbelvin mentioned this pull request Jul 25, 2018

Rename gometalinter gas to gosec google/keytransparency#1024

Merged

gdbelvin added a commit to google/keytransparency that referenced this pull request Jul 25, 2018

Rename gometalinter gas to gosec (#1024)

8522e4b

* Rename gas to gosec Follows alecthomas/gometalinter#505

This was referenced Jul 26, 2018

Cleanup tf-job after a configured TTL kubeflow/trainer#753

Merged

linter: Rename gas to gosec and fix linting errors kubeflow/trainer#758

Merged

Incorrect tag used with pytorch_job_mnist.yaml example kubeflow/pytorch-operator#51

Merged

Random-Liu mentioned this pull request Jul 26, 2018

Unpack image during import. containerd/cri#864

Merged

APwhitehat mentioned this pull request Jul 27, 2018

Change gas to gosec matrix-org/gomatrixserverlib#100

Merged

brentnd mentioned this pull request Jul 31, 2018

Add calls to create and delete required Dynamo tables twitchscience/kinsumer#14

Merged

eine mentioned this pull request Aug 4, 2018

chore: disable gosec filebrowser/filebrowser#490

Merged

hacdias pushed a commit to filebrowser/filebrowser that referenced this pull request Aug 5, 2018

chore(gometalinter): gas is renamed to gosec [alecthomas/gometalinter…

188a07c

…#505]

eine pushed a commit to filebrowser/filebrowser that referenced this pull request Aug 6, 2018

chore(gometalinter): gas is renamed to gosec [alecthomas/gometalinter…

60c89e2

…#505]

eine pushed a commit to filebrowser/filebrowser that referenced this pull request Aug 6, 2018

chore(gometalinter): gas is renamed to gosec [alecthomas/gometalinter…

993bab4

…#505]

andygrunwald added a commit to andygrunwald/go-gerrit that referenced this pull request Aug 8, 2018

gometalinter: Rename gas security checker to gosec

201f25d

See alecthomas/gometalinter#505

zzak mentioned this pull request Aug 16, 2018

Use gometalinter docker image now that it's updated CircleCI-Public/circleci-cli#57

Merged

larcher mentioned this pull request Dec 12, 2018

Update gas linter to new name, gosec cloudflare/cfdeploy#12

Merged

travisperson mentioned this pull request Feb 20, 2019

[bug] Missing dependencies on first install filecoin-project/venus#1966

Closed

Rename gas security checker to gosec #505

Rename gas security checker to gosec #505

Uh oh!

Conversation

ccojocar commented Jul 22, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alecthomas commented Jul 22, 2018

Uh oh!

ccojocar commented Jul 23, 2018

Uh oh!

kolyshkin commented Jul 24, 2018

Uh oh!

alecthomas Jul 24, 2018

Choose a reason for hiding this comment

Uh oh!

alecthomas Jul 24, 2018

Choose a reason for hiding this comment

Uh oh!

alecthomas commented Jul 24, 2018

Uh oh!

ccojocar commented Jul 24, 2018

Uh oh!

alecthomas commented Jul 24, 2018

Uh oh!

thepwagner Jul 24, 2018

Choose a reason for hiding this comment

Uh oh!

ccojocar Jul 24, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

JeanMertz commented Jul 27, 2018

Uh oh!

HaraldNordgren commented Jul 28, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

dnephin commented Jul 28, 2018

Uh oh!

alecthomas commented Jul 28, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

ccojocar commented Jul 22, 2018 •

edited

Loading

ccojocar Jul 24, 2018 •

edited

Loading

HaraldNordgren commented Jul 28, 2018 •

edited

Loading