Improve deadlock deps fix#2
Closed
raythurnvoid wants to merge 1 commit intoaleclarson:feat/ssr-circular-importfrom
raythurnvoid:improve_deadlock_deps_fix
Closed
Improve deadlock deps fix#2raythurnvoid wants to merge 1 commit intoaleclarson:feat/ssr-circular-importfrom raythurnvoid:improve_deadlock_deps_fix
raythurnvoid wants to merge 1 commit intoaleclarson:feat/ssr-circular-importfrom
raythurnvoid:improve_deadlock_deps_fix
Conversation
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Your PR works well with "forked circular dependencies" but it fails when in a circular dependency a module need a value from another module in its stack es:
A --> B --> C --> Awhere
Cneeds a value fromAin order to be initialized, otherwise it throws.i've made a test for this case: https://github.com/raythurnevoid/vite/tree/improve_deadlock_deps_fix/packages/playground/ssr-react/src/circular-dep-init
Actually the fix is still not perfect since it works only when a module actually throws on initialization but this doesn't always happend. This can now be optimized using pendingImports.