Added null character for ftp_password for strcmp#990
Conversation
aldostools
added a commit
that referenced
this pull request
Dec 21, 2023
- Fixed issue with FTP password of 20 characters (issue #990 reported by @jonathan-rosa)
Owner
|
Thank you for the bug report. Although your code seems to be the simplest solution, I did not appove it because the config structure is not backward compatible with existing installations already configured. It would require that all users enter to /setup.ps3 and reconfigure it. I've implemented a backward compatible solution in commit 9949243 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently ftp_password is 20 characters, but if you use all 20 characters, it'll keep reading for strcmp because null character isn't guaranteed--giving a wrong password error. Added ftp_password_null u8 to fix this.