Skip to content

fix mounting /app_home#1074

Closed
bibarub wants to merge 1 commit intoaldostools:masterfrom
bibarub:master
Closed

fix mounting /app_home#1074
bibarub wants to merge 1 commit intoaldostools:masterfrom
bibarub:master

Conversation

@bibarub
Copy link
Copy Markdown
Contributor

@bibarub bibarub commented May 12, 2024

webMAN didn't mount /app_home correctly (it was mounting USRDIR to /app_home. i don't know the reason behind this, but it does not work at all), this commit fixes it

USRDIR-related code has been removed from both map_app_home and set_app_home, the multidisc logic from map_app_home has been commented out (it's completely broken), the conditions in set_app_home have been edited a bit

@bibarub
Copy link
Copy Markdown
Contributor Author

bibarub commented May 12, 2024

(i only tested it on HEN 3.3.0, not sure if it works on CFW)

aldostools added a commit that referenced this pull request May 12, 2024
- Fix mount /app_home code from pull request #1074 by @bibarub
This commit omits the removal of the multi-disc logic
@aldostools
Copy link
Copy Markdown
Owner

@bibarub Thank you for your pull request. I have applied almost all your changes, except the removal of the multi-disc logic.

I added comments explaining how it works. Maybe you didn't get how the logic works. I tested it on CFW some years ago.
Basically it requires to mount the same ISO multiple times to mount PS3_GM02, PS3_GM03, etc.

If the code is broken as you mentioned in your comments, it needs to be fixed not removed 😃

@bibarub
Copy link
Copy Markdown
Contributor Author

bibarub commented May 12, 2024

sorry, didn't think about that at all xD. thank you for merging the code

by the way, change '18' to '11' at line 941 in include/mount/mount.h. the 7 extra bytes were used for "/USRDIR", which we don't touch anymore

also, you forgot to change the comment at line 921 in the same file

@bibarub
Copy link
Copy Markdown
Contributor Author

bibarub commented May 12, 2024

regarding the multi-disc code
don't multi-game discs still use PS3_GAME for the first game? i don't have any multi-game ISOs so i don't know how it works, just asking you to make sure

aldostools added a commit that referenced this pull request May 12, 2024
- Changed memory allocation to save 7 bytes used by USRDIR mapping removed in the previous commit. Thanks @bibarub #1074
@aldostools
Copy link
Copy Markdown
Owner

@bibarub Thank you for your comments and for the PR. The suggested corrections were applied.

If you have additional improvements or find bugs, feel free to let me know. Best regards!!

I'm closing this PR, since I merged the changes directly .

@aldostools aldostools closed this May 12, 2024
@aldostools
Copy link
Copy Markdown
Owner

aldostools commented May 12, 2024

regarding the multi-disc code don't multi-game discs still use PS3_GAME for the first game? i don't have any multi-game ISOs so i don't know how it works, just asking you to make sure

Yes. This DisgeaTriplePlayCollectionFilelist.txt is supposed to be the directory structure from the multi-game disc "Disgea Trilogy Collection" .

I obtained it from this post https://www.psx-place.com/threads/make-multidisc-ps3-game.41758/

Current code seems to cycle only from PS3_GM01 to PS3_GM99, ignoring PS3_GAME if they exist.

I think the line 947 should be changed to gm = 01; sprintf(mpath, "%s/PS3_GAME", path); to fix the issue but I don't have a multi-game ISO to test.

Anyway this only affect noBD consoles that require mount JB games through /app_home. /dev_bdvd show multi-game discs in separated disc icons.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants