Repository navigation
Commit 1ec9ede
minor: make MinIO tests more stable (apache#25092)
## Rationale for this change
I observed PRs sometimes got kicked out of merge queue because flaky
`datafusion-cli` tests, which require full CI again
The `datafusion-cli` storage integration tests (`test_cli`,
`test_aws_options`, `test_s3_url_fallback`,
`test_object_store_profiling`) each start their own MinIO container, so
a single CI run pulls the image several times concurrently. Any
transient Docker failure during that pull fails the test immediately:
```
thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"
```
These errors are transient and clear on a second attempt, so a flaky
pull should not fail the job.
## Rationale for this change
The `datafusion-cli` storage integration tests (`test_cli`,
`test_aws_options`, `test_s3_url_fallback`,
`test_object_store_profiling`) each start their own MinIO container, so
a single CI run pulls the image several times concurrently. Any
transient Docker failure during that pull fails the test immediately:
```
thread 'test_aws_options' panicked at datafusion-cli/tests/cli_integration.rs:607:25:
called `Result::unwrap()` on an `Err` value: "Failed to start MinIO container.
Ensure Docker is running and accessible: failed to pull the image
'minio/minio:RELEASE.2025-02-28T09-55-16Z', error: bytes remaining on stream"
```
These errors are transient and clear on a second attempt, so a flaky
pull should not fail the job.
Co-authored-by: Andrew Lamb <[email protected]>1 parent 4f0faac commit 1ec9ede
2 files changed
Lines changed: 204 additions & 105 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
395 | 395 | | |
396 | 396 | | |
397 | 397 | | |
| 398 | + | |
| 399 | + | |
| 400 | + | |
| 401 | + | |
| 402 | + | |
| 403 | + | |
| 404 | + | |
| 405 | + | |
| 406 | + | |
| 407 | + | |
| 408 | + | |
| 409 | + | |
| 410 | + | |
| 411 | + | |
| 412 | + | |
398 | 413 | | |
399 | 414 | | |
400 | 415 | | |
| |||
0 commit comments