inlet/bmp: avoid long lock times when flushing peers#254
Merged
Conversation
vincentbernat
force-pushed
the
fix/reduce-bmp-lock-time
branch
from
2bc0284 to
47c72d1
Compare
When the RIB is locked for too long, inlet is hung. Try to ensure give a bit of time for the inlet to move forward between two flush of the RIB. There are various knobs not documnted yet until we get better defaults: - `inlet.bmp.peer-removal-max-time`: how long to keep the lock - `inlet.bmp.peer-removal-sleep-interval`: how long to sleep between two runs if we were unable to flush the whole peer - `inlet.bmp.peer-removal-max-queue`: maximum number of flush requests - `inlet.bmp.peer-removal-min-routes`: minimum number of routes to flush before yielding May fix #253
vincentbernat
force-pushed
the
fix/reduce-bmp-lock-time
branch
from
47c72d1 to
f187463
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When the RIB is locked for too long, inlet is hung. Try to ensure give a bit of time for the inlet to move forward between two flush of the RIB. There are various knobs not documnted yet until we get better defaults:
inlet.bmp.peer-removal-max-time: how long to keep the lockinlet.bmp.peer-removal-sleep-interval: how long to sleep between two runs if we were unable to flush the whole peerinlet.bmp.peer-removal-max-queue: maximum number of flush requestsinlet.bmp.peer-removal-min-routes: minimum number of routes to flush before yieldingMay fix #253