addException in deleteAccount (apache#25255)

darkhan.nausharipov · darkhan.nausharipov · commit 09a5526aa9f4 · 2023-02-09T20:08:48.000+06:00
diff --git a/learning/tour-of-beam/frontend/lib/auth/notifier.dart b/learning/tour-of-beam/frontend/lib/auth/notifier.dart
@@ -44,7 +44,6 @@ class AuthNotifier extends ChangeNotifier {
     try {
       await FirebaseAuth.instance.signInWithPopup(authProvider);
     } on Exception catch (e) {
-      // TODO(nausharipov) review: why toasts are not shown in ToB?
       PlaygroundComponents.toastNotifier.addException(e);
     }
   }
@@ -54,7 +53,11 @@ class AuthNotifier extends ChangeNotifier {
   }
 
   Future<void> deleteAccount() async {
-    await client.postDeleteUserProgress();
-    await FirebaseAuth.instance.currentUser?.delete();
+    try {
+      await client.postDeleteUserProgress();
+      await FirebaseAuth.instance.currentUser?.delete();
+    } on Exception catch (e) {
+      PlaygroundComponents.toastNotifier.addException(e);
+    }
   }
 }

Original file line number	Diff line number	Diff line change
`@@ -44,7 +44,6 @@ class AuthNotifier extends ChangeNotifier {`
`44`	`44`	`try {`
`45`	`45`	`await FirebaseAuth.instance.signInWithPopup(authProvider);`
`46`	`46`	`} on Exception catch (e) {`
`47`		`- // TODO(nausharipov) review: why toasts are not shown in ToB?`
`48`	`47`	`PlaygroundComponents.toastNotifier.addException(e);`
`49`	`48`	`}`
`50`	`49`	`}`
`@@ -54,7 +53,11 @@ class AuthNotifier extends ChangeNotifier {`
`54`	`53`	`}`
`55`	`54`
`56`	`55`	`Future<void> deleteAccount() async {`
`57`		`- await client.postDeleteUserProgress();`
`58`		`- await FirebaseAuth.instance.currentUser?.delete();`
	`56`	`+ try {`
	`57`	`+ await client.postDeleteUserProgress();`
	`58`	`+ await FirebaseAuth.instance.currentUser?.delete();`
	`59`	`+ } on Exception catch (e) {`
	`60`	`+ PlaygroundComponents.toastNotifier.addException(e);`
	`61`	`+ }`
`59`	`62`	`}`
`60`	`63`	`}`