Thermal manager fix#27
Closed
VadymYashchenko wants to merge 48 commits intoakokhan:newport_platform_apifrom
Closed
Thermal manager fix#27VadymYashchenko wants to merge 48 commits intoakokhan:newport_platform_apifrom
VadymYashchenko wants to merge 48 commits intoakokhan:newport_platform_apifrom
Conversation
What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API
Signed-off-by: Vadym Yashchenko <[email protected]>
…maximum_recorded() Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
…rature() Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
What I did Add get_model() function Add get_low_critical_threshold() function Change __get(...) function. How I did it Differnece from previous implementation of __get(...) function is return real value or -9999.9 if value is not provided by thrift API
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Dmytro Lytvynenko <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Volodymyr Boyko <[email protected]>
* Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Petro Bratash <[email protected]>
Signed-off-by: Petro Bratash <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Volodymyr Boyko <[email protected]>
…t#21) Signed-off-by: Mykola Gerasymenko <[email protected]>
Signed-off-by: Volodymyr Boyko <[email protected]>
Signed-off-by: Andriy Kokhan <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
…mngr in the Chassis Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
…thermal sensors of cab18-4 Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
… a thermal daemon Signed-off-by: Vadym Yashchenko <[email protected]>
Signed-off-by: Vadym Yashchenko <[email protected]>
Author
|
Long dependencies |
akokhan
pushed a commit
that referenced
this pull request
Mar 28, 2022
ce72b0d Longxiang Lyu Thu Feb 24 06:05:12 2022 Put handler member functions as virtual in base (#30) ef59e4f Jing Zhang Fri Feb 25 11:38:28 2022 Incrementing tolerance on mux state inconsistency (#27) 2d12892 Longxiang Lyu Wed Feb 16 03:32:06 2022 Rename LinkManagerStateMachine to ActiveStandbyStateMachine (#26) f38634c Jing Zhang Thu Feb 17 17:23:56 2022 Update log level for mux probing and mux state chance (#23) a8434dd Jing Zhang Thu Feb 17 17:21:01 2022 Handle xcvrd crashing scenarios (#22) 2ebdb2b Longxiang Lyu Mon Feb 14 13:26:07 2022 [make] Enable make extra includes (#24)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why I did it
I fixed LGTM message for Unnecessary delete statement in function and
Dec 23 10:30:37.956959 sonic INFO telemetry#supervisord 2021-12-23 10:30:37,956 INFO exited: dependent-startup (exit status 0; expected) Dec 23 10:31:05.949734 sonic WARNING pmon#thermalctld: High temperature warning: psu_driver-i2c-7-5a:psu1-temp1 current temperature 27.125C, high threshold -999.9C Dec 23 10:31:41.436897 sonic WARNING pmon#thermalctld: High temperature warning: psu_driver-i2c-7-5a:psu1-temp2 current temperature 38.0C, high threshold -999.9CHow I did it
I reworked ThermalManager and Thermal classes
How to verify it
platform_tests/api/test_chassis.py; platform_tests/api/test_thermal.py; acl/test_acl.py;
Which release branch to backport (provide reason below if selected)
Description for the changelog
A picture of a cute animal (not mandatory but encouraged)