Disable ActivityPub federation for cached friend posts#665
Merged
Conversation
Cached posts are remote content stored locally; they must never be announced as the site's own activity. Hook activitypub_is_post_disabled to short-circuit the ActivityPub plugin's lifecycle handling for the friend_post_cache CPT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
friend_post_cacheCPT) are remote content stored locally and should never be announced as the site's own ActivityPub activity.activitypub_is_post_disabledto short-circuit the ActivityPub plugin's post lifecycle handling for cached posts. Without this, the plugin's lifecycle override could keep firing Updates whenever a cached post is re-fetched if itsactivitypub_statuspost meta was ever set.Test plan
Test in WordPress Playground