Fix loading indicator propeller effect in themes#659
Merged
Conversation
In the Google Reader, Mastodon, and Twitter themes, `.loading` was applied directly to the host element (often a button containing text or an emoji) and rotated the whole element — spinning the content like a propeller. Match the default theme's pattern: keep the theme's border colors/sizes but rotate a `::after` pseudo-element while hiding the host text via `color: transparent`.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.friends-page .loadingrule was applied directly to the host element and rotated the whole element — spinning button text/emoji like a propeller (e.g. on reaction buttons).color: transparentand no animation; a::afterpseudo-element carries the border and rotation. Each theme keeps its own colors and size.Test plan
<i class=\"loading\"></i>indicators (comments loading, pagination) still render a visible spinner.