Add search field to Followers, Following, and Mutual pages#658
Merged
Conversation
Search matches against display name, handle/URL, and description (summary for followers). Filters the in-memory list before category filter/sort/pagination so counts and pagination reflect the search. The existing filter and sort selections are preserved when searching.
Flatten the search markup (drop the inner <p>) and switch to a shared .friends-search class with element-level hooks (label/input/submit/clear). Add matching rules in friends.css and in the Mastodon, Twitter, and Google Reader theme stylesheets so the form blends in instead of using browser defaults.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
?q=search field to/friends/followers/,/friends/following/, and/friends/mutual/with the same UI pattern.includes/class-blocks.phpmirrors the same behavior.Test plan
/friends/followers/?q=alicenarrows the list to matching followers and shows a match count./friends/following/?q=alicenarrows subscriptions to matching people/feeds./friends/mutual/?q=alicenarrows mutuals (uses followers template withfilter=following).qparameter.composer check-cspasses.Test in WordPress Playground