Ignore the text when authorizing to avoid language problems#201
Merged
Conversation
jeherve
reviewed
Feb 17, 2025
Contributor
jeherve
left a comment
jeherve
left a comment
There was a problem hiding this comment.
This worked for me, but could we not check for a non-translatable value instead of just checking for a non-empty value?
Owner
Author
|
Well it's a button label and I want to ensure that you clicked the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the current code we might compare a user language text to a blog language text which might have different languages.