Skip to content

Commit c883410

Browse files
aznashwanAkihiroSuda
authored andcommitted
CI: Explicitly upgrade MinGW on Windows 2019 GitHub runners.
The default version of MinGW and GCC on the GitHub-hosted Windows 2019 runners compile fine but lead to linker errors during runtime. Signed-off-by: Nashwan Azhari <[email protected]>
1 parent 0f043ae commit c883410

1 file changed

Lines changed: 12 additions & 0 deletions

File tree

.github/workflows/ci.yml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -218,6 +218,12 @@ jobs:
218218

219219
- uses: actions/checkout@v3
220220

221+
# NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
222+
# builtin MinGW version leads to DLL loading errors during runtime.
223+
- name: Upgrade MinGW on Windows 2019
224+
if: matrix.os == 'windows-2019'
225+
run: choco upgrade mingw
226+
221227
- name: Make
222228
run: |
223229
make build
@@ -269,6 +275,12 @@ jobs:
269275
270276
- run: script/setup/install-dev-tools
271277

278+
# NOTE(aznashwan): starting with Golang 1.21, the windows-2019 GitHub runner's
279+
# builtin MinGW version leads to DLL loading errors during runtime.
280+
- name: Upgrade MinGW on Windows 2019
281+
if: matrix.os == 'windows-2019'
282+
run: choco upgrade mingw
283+
272284
- name: Binaries
273285
env:
274286
CGO_ENABLED: 1

0 commit comments

Comments
 (0)