Revert "daemon: automatically set network EnableIPv6 if needed"

akerouanton · akerouanton · commit c59e93a67bca · 2024-02-02T10:34:26.000+01:00
This reverts commit 5d5eeac. Signed-off-by: Albin Kerouanton <albinker@gmail.com>
diff --git a/api/types/network/ipam.go b/api/types/network/ipam.go
@@ -30,30 +30,9 @@ const (
 	ip6 ipFamily = "IPv6"
 )
 
-// HasIPv6Subnets checks whether there's any IPv6 subnets in the ipam parameter. It ignores any invalid Subnet and nil
-// ipam.
-func HasIPv6Subnets(ipam *IPAM) bool {
-	if ipam == nil {
-		return false
-	}
-
-	for _, cfg := range ipam.Config {
-		subnet, err := netip.ParsePrefix(cfg.Subnet)
-		if err != nil {
-			continue
-		}
-
-		if subnet.Addr().Is6() {
-			return true
-		}
-	}
-
-	return false
-}
-
 // ValidateIPAM checks whether the network's IPAM passed as argument is valid. It returns a joinError of the list of
 // errors found.
-func ValidateIPAM(ipam *IPAM) error {
+func ValidateIPAM(ipam *IPAM, enableIPv6 bool) error {
 	if ipam == nil {
 		return nil
 	}
@@ -74,6 +53,10 @@ func ValidateIPAM(ipam *IPAM) error {
 			errs = append(errs, fmt.Errorf("invalid subnet %s: it should be %s", subnet, subnet.Masked()))
 		}
 
+		if !enableIPv6 && subnetFamily == ip6 {
+			errs = append(errs, fmt.Errorf("invalid subnet %s: IPv6 has not been enabled for this network", subnet))
+		}
+
 		if ipRangeErrs := validateIPRange(cfg.IPRange, subnet, subnetFamily); len(ipRangeErrs) > 0 {
 			errs = append(errs, ipRangeErrs...)
 		}
diff --git a/api/types/network/ipam_test.go b/api/types/network/ipam_test.go
@@ -30,6 +30,12 @@ func TestNetworkWithInvalidIPAM(t *testing.T) {
 				"invalid auxiliary address DefaultGatewayIPv4: parent subnet is an IPv4 block",
 			},
 		},
+		{
+			name:           "IPv6 subnet is discarded when IPv6 is disabled",
+			ipam:           IPAM{Config: []IPAMConfig{{Subnet: "2001:db8::/32"}}},
+			ipv6:           false,
+			expectedErrors: []string{"invalid subnet 2001:db8::/32: IPv6 has not been enabled for this network"},
+		},
 		{
 			name: "Invalid data - Subnet",
 			ipam: IPAM{Config: []IPAMConfig{{Subnet: "foobar"}}},
@@ -122,7 +128,7 @@ func TestNetworkWithInvalidIPAM(t *testing.T) {
 		t.Run(tc.name, func(t *testing.T) {
 			t.Parallel()
 
-			errs := ValidateIPAM(&tc.ipam)
+			errs := ValidateIPAM(&tc.ipam, tc.ipv6)
 			if tc.expectedErrors == nil {
 				assert.NilError(t, errs)
 				return
diff --git a/daemon/network.go b/daemon/network.go
@@ -305,10 +305,6 @@ func (daemon *Daemon) createNetwork(cfg *config.Config, create types.NetworkCrea
 		return nil, errdefs.Forbidden(errors.New(`This node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again.`))
 	}
 
-	if network.HasIPv6Subnets(create.IPAM) {
-		create.EnableIPv6 = true
-	}
-
 	networkOptions := make(map[string]string)
 	for k, v := range create.Options {
 		networkOptions[k] = v
@@ -335,7 +331,7 @@ func (daemon *Daemon) createNetwork(cfg *config.Config, create types.NetworkCrea
 		nwOptions = append(nwOptions, libnetwork.NetworkOptionConfigOnly())
 	}
 
-	if err := network.ValidateIPAM(create.IPAM); err != nil {
+	if err := network.ValidateIPAM(create.IPAM, create.EnableIPv6); err != nil {
 		return nil, errdefs.InvalidParameter(err)
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -305,10 +305,6 @@ func (daemon Daemon) createNetwork(cfg config.Config, create types.NetworkCrea`
`305`	`305`	return nil, errdefs.Forbidden(errors.New(`This node is not a swarm manager. Use "docker swarm init" or "docker swarm join" to connect this node to swarm and try again.`))
`306`	`306`	`}`
`307`	`307`
`308`		`- if network.HasIPv6Subnets(create.IPAM) {`
`309`		`- create.EnableIPv6 = true`
`310`		`- }`
`311`		`-`
`312`	`308`	`networkOptions := make(map[string]string)`
`313`	`309`	`for k, v := range create.Options {`
`314`	`310`	`networkOptions[k] = v`
`@@ -335,7 +331,7 @@ func (daemon Daemon) createNetwork(cfg config.Config, create types.NetworkCrea`
`335`	`331`	`nwOptions = append(nwOptions, libnetwork.NetworkOptionConfigOnly())`
`336`	`332`	`}`
`337`	`333`
`338`		`- if err := network.ValidateIPAM(create.IPAM); err != nil {`
	`334`	`+ if err := network.ValidateIPAM(create.IPAM, create.EnableIPv6); err != nil {`
`339`	`335`	`return nil, errdefs.InvalidParameter(err)`
`340`	`336`	`}`
`341`	`337`