libnetwork: remove global store from windows overlay driver

akerouanton · akerouanton · commit 5e9e400474a5 · 2023-03-02T17:10:29.000+01:00
The overlay driver was creating a global store whenever netlabel.GlobalKVClient was specified in its config argument. This specific label is not used anymore since 142b522 (moby#44875). Signed-off-by: Albin Kerouanton <albinker@gmail.com>
diff --git a/libnetwork/drivers/windows/overlay/overlay_windows.go b/libnetwork/drivers/windows/overlay/overlay_windows.go
@@ -23,7 +23,6 @@ const (
 type driver struct {
 	config     map[string]interface{}
 	networks   networkTable
-	store      datastore.DataStore
 	localStore datastore.DataStore
 	once       sync.Once
 	joinOnce   sync.Once
@@ -42,18 +41,6 @@ func Register(r driverapi.Registerer, config map[string]interface{}) error {
 		config:   config,
 	}
 
-	if data, ok := config[netlabel.GlobalKVClient]; ok {
-		var err error
-		dsc, ok := data.(discoverapi.DatastoreConfigData)
-		if !ok {
-			return types.InternalErrorf("incorrect data in datastore configuration: %v", data)
-		}
-		d.store, err = datastore.NewDataStoreFromConfig(dsc)
-		if err != nil {
-			return types.InternalErrorf("failed to initialize data store: %v", err)
-		}
-	}
-
 	if data, ok := config[netlabel.LocalKVClient]; ok {
 		var err error
 		dsc, ok := data.(discoverapi.DatastoreConfigData)
