Repository navigation
fix: package zod with desktop sidecar - #165
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
zodruntime package underdist-electron/node_modulesinstead of relying on pnpm's symlinkextraResourcesProblem
The v0.6.3 Linux package starts Electron, but its Local Host exits before becoming healthy:
zodis deliberately external because bundling its cyclic v4 modules breaks schema construction. The existingnode_modules/zod/**/*file rule does not follow pnpm's symlink into the packaged application, so no resolvable Zod package reaches the release artifact. Electron Builder also filters nestednode_modulesfrom ordinaryfiles, so the materialized package is delivered explicitly withextraResources.Verification
pnpm run checkpnpm vp test scripts/electron-package-metadata.test.tspnpm run buildpnpm run test:package-smokepnpm exec electron-builder --linux deb --publish never.deb, verifiedresources/app.asar.unpacked/dist-electron/node_modules/zod/package.json, and started itsbackend.js; it remained healthy through the 8-second smoke timeout--maxWorkers=1; the browser audit could not launch Chromium because this Ubuntu host disables its usable sandbox