fix(ci): pass vars context as explicit input to composite action#3013
Merged
ygrishajev merged 1 commit intomainfrom Mar 30, 2026
Merged
fix(ci): pass vars context as explicit input to composite action#3013ygrishajev merged 1 commit intomainfrom
ygrishajev merged 1 commit intomainfrom
Conversation
Runner v2.333.0 fixed a bug where `allowCaseFunction` was passed positionally into `allowUnknownKeywords`, accidentally making the parser accept any named-value in composite actions. This broke our use of `vars.GH_USER_TO_SLACK_USER` directly in the run-e2e-tests composite action. Pass it as an explicit input from the calling workflows instead. Ref: actions/runner#4279
stalniy
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Runner v2.333.0 (actions/runner#4279) fixed a bug where
allowCaseFunctionwas passed positionally into theallowUnknownKeywordsparameter inExpressionParser.CreateTree. This accidentally made the parser accept any named-value — includingvars— in composite action templates. With the fix,varsis correctly rejected in composite actions, breaking ourrun-e2e-testsaction.What
gh-user-to-slack-userinput to therun-e2e-testscomposite actionvars.GH_USER_TO_SLACK_USER→inputs.gh-user-to-slack-userin the composite actionvars.GH_USER_TO_SLACK_USERas an explicit input from all calling workflows (console-api-release,provider-proxy-release)