Repository navigation
db: accept a UTF-8 BOM at the start of db.txt - #1357
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Co-Authored-By: Claude Opus 5.5 <[email protected]>
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The new plaintext
db.txtis meant to be editable by hand, but if it gets saved with a UTF-8 byte order mark, zoxide can't open it anymore. Windows PowerShell 5.1'sSet-Content -Encoding utf8writes one, and so does Notepad's "UTF-8 with BOM":The BOM is invisible, so the timestamp in the message looks fine. Since
zand the prompt hook both open the database, zoxide stays broken until the file is fixed by hand.This strips a leading BOM before parsing, like the trailing
\rthat's already ignored for CRLF files. The next save writes the file without it. Added a test that opens adb.txtstarting with a BOM.I used Claude Code to write this change.