Skip to content

Commit 260482b

Browse files
committed
fix(inject): read assistant body from data.message.content (Issue slow-stack#129)
assistant/message(以及 tool/result)的消息体嵌在 data.message 下(DSH 侧由 @deepseek-ai/dsh-session 的 assertMessageEventShape 写死:type === "user/message" ? record : record?.["message"]),而 textOf 只读 event.data.content,于是热记忆块里 每一轮的 A 恒为空。 改用 ?? 兜底而不是直接替换:user 消息与旧的扁平形状都照旧可用。 同时修正一处测试夹具错误:原用例给 assistant 事件喂的是 data.content,与当时有 bug 的实现是同一个错误假设,因此永远抓不到这个回归;已改为真实形状,并补两个用例 (N 轮 A 不空 / 扁平形状仍兼容)。 npm test: 814 tests, 813 pass, 0 fail, 1 skipped.
1 parent 3b2b443 commit 260482b

3 files changed

Lines changed: 49 additions & 3 deletions

File tree

‎dsh-mneme/lib/inject.js‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@ function extractRounds(ctx, maxRounds) {
4444
const rounds = [];
4545
let pendingQuery = null;
4646
const textOf = (event) => {
47-
const parts = event?.data?.content;
47+
// user/message 的正文就在 data 上,而 assistant/message(以及 tool/result)的消息体
48+
// 嵌在 data.message 下 —— DSH 侧由 @deepseek-ai/dsh-session 的
49+
// assertMessageEventShape 一行写死:const message = type === "user/message" ? record : record?.["message"]。
50+
// 只读 data.content 会让每一轮的 response 恒为空(Issue #129)。
51+
// 这里用 ?? 兜底而不是直接改成 data.message.content:user 消息与旧的扁平形状都照旧可用。
52+
const parts = event?.data?.content ?? event?.data?.message?.content;
4853
if (!Array.isArray(parts)) return "";
4954
return parts
5055
.map((p) => (typeof p === "string" ? p : p?.text ?? ""))

‎dsh-mneme/src/inject.js‎

Lines changed: 6 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -44,7 +44,12 @@ function extractRounds(ctx, maxRounds) {
4444
const rounds = [];
4545
let pendingQuery = null;
4646
const textOf = (event) => {
47-
const parts = event?.data?.content;
47+
// user/message 的正文就在 data 上,而 assistant/message(以及 tool/result)的消息体
48+
// 嵌在 data.message 下 —— DSH 侧由 @deepseek-ai/dsh-session 的
49+
// assertMessageEventShape 一行写死:const message = type === "user/message" ? record : record?.["message"]。
50+
// 只读 data.content 会让每一轮的 response 恒为空(Issue #129)。
51+
// 这里用 ?? 兜底而不是直接改成 data.message.content:user 消息与旧的扁平形状都照旧可用。
52+
const parts = event?.data?.content ?? event?.data?.message?.content;
4853
if (!Array.isArray(parts)) return "";
4954
return parts
5055
.map((p) => (typeof p === "string" ? p : p?.text ?? ""))

‎dsh-mneme/test/inject.test.js‎

Lines changed: 37 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,16 +105,52 @@ test("Bug6: injected block stays within the ~1500 char budget, later entries col
105105
// DSH ≥0.1.2-rc removed Session.events; events are only reachable via
106106
// snapshotEvents(). Regression for #59: the hot block must still render from
107107
// a session object that has no .events property.
108+
// 注意:assistant/message 的消息体在 data.message 下(见 Issue #129),夹具必须用这个
109+
// 真实形状 —— 原先的夹具写的是 data.content,与当时有 bug 的实现是同一个错误假设,
110+
// 所以它永远抓不到这个回归。
108111
test("extracts hot rounds from snapshotEvents() when Session.events is absent", () => {
109112
const { contexts } = setup();
110113
const session = {
111114
snapshotEvents: () => [
112115
{ type: "user/message", data: { source: { kind: "user" }, content: [{ type: "text", text: "怎么修图谱面板" }] } },
113-
{ type: "assistant/message", data: { content: [{ type: "text", text: "用 viewBox 单位跑模拟" }] } }
116+
{ type: "assistant/message", data: { message: { content: [{ type: "text", text: "用 viewBox 单位跑模拟" }] } } }
114117
]
115118
};
116119
const text = contexts[0].text({ agent: { session } });
117120
assert.ok(text.includes("[短期上下文]"), "hot block rendered");
118121
assert.ok(text.includes("怎么修图谱面板"), "round query present");
119122
assert.ok(text.includes("用 viewBox 单位跑模拟"), "round response present");
120123
});
124+
125+
// Issue #129 的复现:assistant 轮的正文取自 data.message.content。修复前 textOf 只读
126+
// data.content,于是每一轮的 response 都落成空串 —— 表现为「N 轮 A 全空」。
127+
test("Issue #129: response 取自 data.message.content,N 轮不再出现空 A", () => {
128+
const { contexts } = setup();
129+
const session = {
130+
snapshotEvents: () => [
131+
{ type: "user/message", data: { source: { kind: "user" }, content: [{ type: "text", text: "第一个问题" }] } },
132+
{ type: "assistant/message", data: { message: { content: [{ type: "text", text: "第一个回答" }] } } },
133+
{ type: "user/message", data: { source: { kind: "user" }, content: [{ type: "text", text: "第二个问题" }] } },
134+
{ type: "assistant/message", data: { message: { content: [{ type: "text", text: "第二个回答" }] } } }
135+
]
136+
};
137+
const text = contexts[0].text({ agent: { session } });
138+
for (const s of ["第一个问题", "第一个回答", "第二个问题", "第二个回答"]) {
139+
assert.ok(text.includes(s), `hot block 应包含 ${s}`);
140+
}
141+
});
142+
143+
// 修复用的是 ?? 兜底而非破坏性替换:扁平的 data.content 形状(user 消息一贯如此,
144+
// 历史事件也可能如此)必须继续可用。
145+
test("Issue #129: 扁平的 data.content 形状仍被兼容", () => {
146+
const { contexts } = setup();
147+
const session = {
148+
snapshotEvents: () => [
149+
{ type: "user/message", data: { source: { kind: "user" }, content: [{ type: "text", text: "问题" }] } },
150+
{ type: "assistant/message", data: { content: [{ type: "text", text: "扁平形状的回答" }] } }
151+
]
152+
};
153+
const text = contexts[0].text({ agent: { session } });
154+
assert.ok(text.includes("问题"), "query present");
155+
assert.ok(text.includes("扁平形状的回答"), "flat content shape still supported");
156+
});

0 commit comments

Comments
 (0)