Fix issubclass() TypeError and make temperature/top_p optional#705
Merged
ahmetgunduz merged 1 commit intodevelopmentfrom Oct 22, 2025
Merged
Conversation
- Fix issubclass() TypeError in Agent.run_async when expected_output is not a class Add isinstance(expected_output, type) check before calling issubclass() to prevent TypeError when expected_output is a tuple or other non-class value. Fixes test_run_normalizes_expected_output_tuple_to_list_in_execution_params - Fix instructions fallback in AgentFactory.create When instructions is None, properly fall back to description instead of converting None to string 'None' - Make temperature and top_p parameters optional in LLM model Change default values from 0.001 and 1.0 to None, and only include them in parameters dict when they have non-None values - Add missing docstrings and move module docstrings to top of files to fix linting errors
xainaz
approved these changes
Oct 22, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix issubclass() TypeError in Agent.run_async when expected_output is not a class
Add isinstance(expected_output, type) check before calling issubclass() to prevent
TypeError when expected_output is a tuple or other non-class value.
Fixes test_run_normalizes_expected_output_tuple_to_list_in_execution_params
Fix instructions fallback in AgentFactory.create
When instructions is None, properly fall back to description instead of
converting None to string 'None'
Make temperature and top_p parameters optional in LLM model
Change default values from 0.001 and 1.0 to None, and only include them
in parameters dict when they have non-None values
Add missing docstrings and move module docstrings to top of files to fix linting errors