normalized expected output from basemodel#685
Merged
ahmetgunduz merged 2 commits intodevelopmentfrom Sep 24, 2025
Merged
Conversation
ahmetgunduz
suggested changes
Sep 23, 2025
Contributor
ahmetgunduz
left a comment
ahmetgunduz
left a comment
There was a problem hiding this comment.
lets add some unit tests for normalize_expected_output
| @@ -365,6 +366,7 @@ def run_async( | |||
| expected_output = self.expected_output | |||
| if expected_output is not None and issubclass(expected_output, BaseModel): | |||
Contributor
There was a problem hiding this comment.
this part can be removed isnt it?
ahmetgunduz
approved these changes
Sep 24, 2025
ahmetgunduz
deleted the
PROD-1957-allow-pydantic-objects-as-expected-output-for-agents-team-agents
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.