Skip to content

Commit e87847a

Browse files
committed
Removed dependency on specific matplotlib version
* Method set_aspect('equal') does not work in latest version of 'matplotlib' * See: matplotlib/matplotlib#1077
1 parent 162a7d8 commit e87847a

4 files changed

Lines changed: 7 additions & 19 deletions

File tree

‎docs/TODO.md‎

Lines changed: 0 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -123,21 +123,5 @@
123123
* "Python3.6-devel" is required for "Python.h" header file (i.e. to compile the C/C++ code)
124124
* `tkinter` may have to be installed separately for matplotlib to work (not included in matplotlib PyPI package?)
125125

126-
### Error with matplotlib version 3.1.1 (2019-08-14)
127-
* Matplotlib version 3.1.1 throws NotImplementedError! Force version 3.0.2 for now
128-
129-
```
130-
Traceback (most recent call last):
131-
File "main.py", line 57, in <module>
132-
pyt.standard_run(args)
133-
File ".../pytornado/stdfun.py", line 193, in standard_run
134-
pl_geometry.view_aircraft(aircraft, plt_settings, plot='norm')
135-
File ".../pytornado/plot/geometry.py", line 77, in view_aircraft
136-
axes_xyz.set_aspect('equal')
137-
File ".../matplotlib/axes/_base.py", line 1281, in set_aspect
138-
'It is not currently possible to manually set the aspect '
139-
NotImplementedError: It is not currently possible to manually set the aspect on 3D axes
140-
```
141-
142126
## General reminders
143127
* Direction of normal can have influence on the sign of the pressure coefficient

‎requirements.txt‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ aeroframe>=0.0.4
44
airfoils>=0.2.0
55
codecov==2.0.15
66
commonlibs>=0.3.3
7-
matplotlib==3.0.2
7+
matplotlib>=3.0.2
88
numpy==1.16.4
99
pytest-cov==2.7.1
1010
pytest==5.0.1

‎setup.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,7 @@
3434
'ambiance',
3535
'numpy',
3636
'scipy',
37-
'matplotlib==3.0.2',
37+
'matplotlib>=3.0.2',
3838
'commonlibs>=0.3.3',
3939
]
4040
README = 'README.rst'

‎src/lib/pytornado/plot/plottools.py‎

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -264,7 +264,11 @@ def _init_plot3d(title=''):
264264

265265
figure_3d = plt.figure(figsize=(12, 12), edgecolor=C.BLACK)
266266
axes_3d = figure_3d.gca(projection='3d')
267-
axes_3d.set_aspect('equal')
267+
268+
# --> Matplotlib version 3.1.1 raises NotImplementedError
269+
# --> See: https://github.com/matplotlib/matplotlib/issues/1077
270+
#
271+
# axes_3d.set_aspect('equal')
268272

269273
# Add labels
270274
axes_3d.set_xlabel('X [m]')

0 commit comments

Comments
 (0)