feat: generate self-signed pgbouncer certs with script #718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
added
the
status/ready-to-merge
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
What does your PR do?
This PR changes the way we generate self-signed certificates for PgBouncer, so that we no longer uses the helm
genSelfSignedCertfunction, which was causing the manifests to show as perpetually "out of sync" in systems like ArgoCD (as each time this function runs, it generates a unique certificate).We now use our script
/home/pgbouncer/config/gen_self_signed_cert.shwhich runs on startup and generates a self-signed SSL certificate using theopensslcommand line (if the user does not provide their own "existingSecret" for the client certificates).This PR also updates the default PgBouncer image to
ghcr.io/airflow-helm/pgbouncer:1.18.0-patch.1as this was the first version in which we included theopensslCLI.Checklist
For all Pull Requests