Skip to content

fix: some breaking changes from airflow 2.3.0 #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thesuperzapper merged 1 commit into from
Jun 22, 2022
Merged

fix: some breaking changes from airflow 2.3.0 #592

thesuperzapper merged 1 commit into from
Jun 22, 2022

Conversation

@thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented May 31, 2022 •
edited
Loading

What issues does your PR fix?

What does your PR do?

  • Fixes breaking changes introduced in Airflow 2.3.0 (but does not update the default airflow image tag)
    • Sets the AIRFLOW__DATABASE__SQL_ALCHEMY_CONN_CMD variable (as AIRFLOW__CORE__SQL_ALCHEMY_CONN_CMD was not correctly depreciated in Airflow 2.3.0)
    • Fixes sync-users script by updating imports for User and Role models, first trying airflow.www.fab_security.sqla.models (Airflow 2.3+) and if that fails, flask_appbuilder.security.sqla.models (Airflow <2.3)

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone May 31, 2022
@thesuperzapper thesuperzapper mentioned this pull request Jun 3, 2022
Closed
4 tasks
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 6, 2022
@thesuperzapper thesuperzapper mentioned this pull request Jun 14, 2022
Closed
2 tasks
@thesuperzapper thesuperzapper changed the title fix: work around airflow 2.3.0 issues fix: breaking changes from airflow 2.3.0 Jun 21, 2022
@thesuperzapper thesuperzapper changed the title fix: breaking changes from airflow 2.3.0 fix: some breaking changes from airflow 2.3.0 Jun 21, 2022
@thesuperzapper thesuperzapper merged commit 2268f24 into airflow-helm:main Jun 22, 2022
@thesuperzapper thesuperzapper deleted the fix-airflow-2.3.0 branch June 22, 2022 07:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Issue Triage and PR Tracking
Archived in project

Milestone

airflow-8.6.1

Development

Successfully merging this pull request may close these issues.

airflow 2.3.X breaks sync-users script Airflow 2.3.0 Support

1 participant

@thesuperzapper