Skip to content

fix: require release-name to have <= 40 characters #589

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thesuperzapper merged 2 commits into from
Jun 22, 2022
Merged

fix: require release-name to have <= 40 characters #589

thesuperzapper merged 2 commits into from
Jun 22, 2022

Conversation

@seunggabi
Copy link
Contributor

@seunggabi seunggabi commented May 26, 2022 •
edited by thesuperzapper
Loading

What issues does your PR fix?

What does your PR do?

  • Lowers the maximum length of the helm release name to 40 (down from 43)
  • This is needed because the embedded PostgreSQL and Redis charts will create a StatefulSets having a name that is 54 characters long when the helm release is 41 characters long, making it unable to create Pods (StatefulSet with long name can not create pods kubernetes/kubernetes#64023)
  • As an escape hatch for people with existing deployments that have release names between 41 and 43 characters, a hidden value called allowLongReleaseName has been added, which reverts to the previous limit of 43.

Checklist

For all Pull Requests

For releasing ONLY

@seunggabi seunggabi requested a review from thesuperzapper as a code owner May 26, 2022 11:25
@thesuperzapper thesuperzapper changed the title fix(#588): release name length <= 40 fix: release name length <= 40 Jun 6, 2022
@thesuperzapper thesuperzapper changed the title fix: release name length <= 40 fix: require release name length <= 40 Jun 6, 2022
@thesuperzapper thesuperzapper changed the title fix: require release name length <= 40 fix: require release name <= 40 length Jun 6, 2022
@thesuperzapper thesuperzapper changed the title fix: require release name <= 40 length fix: require release name have <= 40 characters Jun 6, 2022
thesuperzapper
thesuperzapper previously approved these changes Jun 7, 2022
View reviewed changes
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 7, 2022
@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone Jun 16, 2022
@thesuperzapper thesuperzapper changed the title fix: require release name have <= 40 characters fix: require helm release name have <= 40 characters Jun 22, 2022
@thesuperzapper thesuperzapper changed the title fix: require helm release name have <= 40 characters fix: require helm release name to have <= 40 characters Jun 22, 2022
@thesuperzapper thesuperzapper changed the title fix: require helm release name to have <= 40 characters fix: require helm release-name to have <= 40 characters Jun 22, 2022
@thesuperzapper thesuperzapper changed the title fix: require helm release-name to have <= 40 characters fix: require release-name to have <= 40 characters Jun 22, 2022
@thesuperzapper thesuperzapper merged commit 4ed2be1 into airflow-helm:main Jun 22, 2022
@seunggabi
Copy link
Contributor Author

seunggabi commented Jun 22, 2022 •
edited
Loading

@thesuperzapper
thx to approving & have a nice day~

@seunggabi seunggabi deleted the fix/release-name-length-40 branch June 22, 2022 08:47
@thesuperzapper
Copy link
Member

thesuperzapper commented Jun 22, 2022

@seunggabi thanks heaps for finding this issue!

Hopefully, we can collaborate more in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesuperzapper thesuperzapper thesuperzapper left review comments

Assignees

No one assigned

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Issue Triage and PR Tracking
Archived in project

Milestone

airflow-8.6.1

Development

Successfully merging this pull request may close these issues.

postgres/redis not deployed if release name > 40 characters

2 participants

@seunggabi @thesuperzapper