feat: allow using extraVolumeMounts for log storage #585
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thesuperzapper
changed the title
2 tasks
thesuperzapper
added
the
status/ready-to-merge
thesuperzapper
force-pushed
the
allow-extra-volume-mounts-for-logs
branch
from
14eabe1 to
1a29392
Compare
Signed-off-by: Mathew Wicks <[email protected]>
thesuperzapper
force-pushed
the
allow-extra-volume-mounts-for-logs
branch
from
1a29392 to
a476726
Compare
thesuperzapper
changed the title
Signed-off-by: Mathew Wicks <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issues does your PR fix?
airflow.extraVolumeMountsto store logs #571What does your PR do?
logs.pathbeing under a customairflow.extraVolumeMountsby detecting when this happens and disabling theemptyDirVolume mounted atlogs.path(originally broken by feat: add log-cleanup sidecar to scheduler/worker #554)airflow.extraVolumeMountsfor logs at the same time as log-cleanup. This is for the same reasons as withlogs.persistence, namely that multiple pods would fight over deleting, but mostly because auto-deleting logs is usually not what the user wants if they enable persistence."Option 3 - Pod Volumes"to the"How to persist airflow logs?"FAQ pageChecklist
For all Pull Requests
For releasing ONLY