Skip to content

fix: wait-for-db-migrations in airflow 2.3.0 #576

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
thesuperzapper merged 1 commit into from
Jun 22, 2022
Merged

fix: wait-for-db-migrations in airflow 2.3.0 #576

thesuperzapper merged 1 commit into from
Jun 22, 2022

Conversation

@maxsteele-shelf
Copy link
Contributor

@maxsteele-shelf maxsteele-shelf commented May 4, 2022 •
edited by thesuperzapper
Loading

What issues does your PR fix?

What does your PR do?

  • Fixes an issue due to a breaking change in Airflow 2.3.0 where the db-migration logic always thinks there are pending migrations if timeout=0.
  • This change should be backward-compatible with pre-Airflow 2.3.0 as well, it'll just loop one more time.

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to the airflow-8.6.1 milestone May 31, 2022
@thesuperzapper
Copy link
Member

thesuperzapper commented May 31, 2022

@maxsteele-shelf I think this is actually a bug in airflow, so I raised an issue here: apache/airflow#24060.

But I agree we need to work around this issue, I will take a look so we can get this merged in chart version 8.6.0.

@thesuperzapper thesuperzapper changed the title fix: Update check-migrations to have non-zero timeout fix: db-migrations script for airflow 2.3 May 31, 2022
@thesuperzapper thesuperzapper mentioned this pull request Jun 3, 2022
Closed
4 tasks
@thesuperzapper
Copy link
Member

thesuperzapper commented Jun 6, 2022

@maxsteele-shelf It seems that Airflow 2.3.2 has resolved this issue with apache/airflow#24068.

However, so that 2.3.1 and 2.3.0 work properly, we will still merge this fix.

@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Jun 6, 2022
@thesuperzapper thesuperzapper changed the title fix: db-migrations script for airflow 2.3 fix: wait-for-db-migrations in airflow 2.3.0 Jun 22, 2022
@thesuperzapper thesuperzapper merged commit 6c792de into airflow-helm:main Jun 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thesuperzapper thesuperzapper thesuperzapper approved these changes

Assignees

No one assigned

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Issue Triage and PR Tracking
Archived in project

Milestone

airflow-8.6.1

Development

Successfully merging this pull request may close these issues.

2 participants

@maxsteele-shelf @thesuperzapper