Skip to content

Conversation

@thesuperzapper
Copy link
Member

What issues does your PR fix?

  • N/A

What does your PR do?

  • Cast user-provided values with toString before passing to b64enc, preventing helm syntax errors if int-type values are passed when strings are expected.
    • NOTE: this is most likely to affect user/password values, as number-only values are possible:
      • externalDatabase.user
      • externalDatabase.password
      • externalRedis.password

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Apr 4, 2022
@thesuperzapper thesuperzapper merged commit 26e8029 into airflow-helm:main Apr 4, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Apr 4, 2022
@thesuperzapper thesuperzapper deleted the ensure-envs-are-string branch April 4, 2022 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant