Skip to content

Conversation

@thesuperzapper
Copy link
Member

@thesuperzapper thesuperzapper commented Mar 25, 2022

What issues does your PR fix?

What does your PR do?

  • Adds an optional "task creation check" to the scheduler liveness probe:
    • scheduler.livenessProbe.taskCreationCheck.enabled (default: false)
    • scheduler.livenessProbe.taskCreationCheck.thresholdSeconds (default: 300)
  • Adds a new FAQ "How to configure the scheduler liveness probe?" with sub-sections:
    • Scheduler "Heartbeat Check"
    • Scheduler "Task Creation Check"
  • Runs the scheduler livenessProbe with /entrypoint:
    • NOTE: this ensures any fixes inside /entrypoint are applied in our livenessProbe
    • NOTE: this improves support for running as root (airflow python packages will not be visible otherwise)
  • Makes the scheduler livenessProbe use fewer resources by:
    1. Only querying the .first() instance of SchedulerJob from the database
    2. Setting airflow log-level to ERROR
    3. Running python under dumb-init (so processes are cleaned up)

Checklist

For all Pull Requests

For releasing ONLY

@thesuperzapper thesuperzapper added this to the airflow-8.6.0 milestone Mar 25, 2022
@thesuperzapper thesuperzapper added the status/ready-to-merge status - this will be merged into next release label Mar 25, 2022
@thesuperzapper thesuperzapper force-pushed the task-creation-scheduler-probe branch from 0d55c1e to 02e821d Compare March 28, 2022 06:34
@thesuperzapper thesuperzapper merged commit f870c67 into airflow-helm:main Mar 31, 2022
@thesuperzapper thesuperzapper deleted the task-creation-scheduler-probe branch March 31, 2022 23:23
@thesuperzapper thesuperzapper mentioned this pull request Apr 19, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

status/ready-to-merge status - this will be merged into next release

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

1 participant